use javascript to open new tab for external links #5159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
sphinx-new-tab-link
dependency for addingtarget="_blank"
to external links in favor of using a simple custom javascript file to achieve the same effect.Why are the changes needed?
The
sphinx-new-tab-link
dependency caused an unintended change in the html/css styling of the site (black border on table elements):sphinx-new-tab-link
depends onsphinxcontrib-extdevhelper-kasane
, (repo), which seems to modify the way the html docs are rendered in a non-obvious way.What changes were proposed in this pull request?
Use sphinx's supported way of customizing docs with a
custom.js
file that achieves the same thing, but without the additional python dependency.How was this patch tested?
Docs built locally with
make docs