Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong syntax for path filtering in validate-helm-charts.yaml #5056

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

lowc1012
Copy link
Contributor

@lowc1012 lowc1012 commented Mar 14, 2024

Tracking issue

NA

Why are the changes needed?

The original workflow can not be triggered correctly because of wrong path filtering.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.99%. Comparing base (d5784e5) to head (7c4e7c3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5056      +/-   ##
==========================================
- Coverage   59.83%   58.99%   -0.84%     
==========================================
  Files         463      645     +182     
  Lines       37631    55578   +17947     
==========================================
+ Hits        22518    32791   +10273     
- Misses      13426    20195    +6769     
- Partials     1687     2592     +905     
Flag Coverage Δ
unittests 58.99% <ø> (-0.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 14, 2024
@eapolinario eapolinario enabled auto-merge (squash) March 14, 2024 22:35
@eapolinario eapolinario merged commit 0b1253b into flyteorg:master Mar 14, 2024
46 of 48 checks passed
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
…teorg#5056)

Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants