Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] artf/impl create get #4258

Merged

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Oct 18, 2023

  • Add a basic blob store interface for offloading model cards
  • Simplified model so that it just wraps the IDL message and adds some fields rather than copying the extra fields.
  • Add a transformer block for gorm models and piped through Create.
  • Update the database code in stdlib config to take a separate config parameter so callers can choose to override the top level database settings.

Also added some suggestions for the proto messages, what do you think @eapolinario ?

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
…rmer, add a blob store for offloading model cards

Signed-off-by: Yee Hing Tong <[email protected]>
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c659aa) 63.29% compared to head (5e8af6e) 60.03%.

❗ Current head 5e8af6e differs from pull request most recent head b14d8da. Consider uploading reports for the commit b14d8da to get more accurate results

Additional details and impacted files
@@                        Coverage Diff                         @@
##           artifacts-bring-admin-monorepo    #4258      +/-   ##
==================================================================
- Coverage                           63.29%   60.03%   -3.27%     
==================================================================
  Files                                 208      387     +179     
  Lines                               16801    26845   +10044     
==================================================================
+ Hits                                10635    16116    +5481     
- Misses                               5387     9231    +3844     
- Partials                              779     1498     +719     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 365 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…l unique on pdn, update create to first look up key, add non-tag version of get

Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor changed the title [wip] artf/impl create get channel [wip] artf/impl create get Oct 20, 2023
@wild-endeavor wild-endeavor merged commit 729b300 into artifacts-bring-admin-monorepo Oct 20, 2023
@wild-endeavor wild-endeavor deleted the artf/impl-create-get-channel branch October 20, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant