Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flyte-data-config ConfigMap to sandbox kustomization #379

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

sbrunk
Copy link
Member

@sbrunk sbrunk commented Jul 7, 2020

I've been playing with raw containers and this seemed to be missing piece to run the flytecopilot container successfully.

@kumare3
Copy link
Contributor

kumare3 commented Jul 7, 2020

@sbrunk Thank you so much, awesome!. Ya CoPilot is not yet announced feature - but you have dug it out :)

@kumare3
Copy link
Contributor

kumare3 commented Jul 7, 2020

you have to run make kustomize

@sbrunk sbrunk force-pushed the sandbox-flyte-data-config branch from 3a9b576 to 9c007c1 Compare July 8, 2020 07:18
@sbrunk
Copy link
Member Author

sbrunk commented Jul 8, 2020

Oh I just wanted to try the test workflows and sample notebooks I found when looking into flytekit :)

I've updated my branch with the generated yaml. The kustomize and diff check passes now.

Copy link
Contributor

@kumare3 kumare3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kumare3 kumare3 merged commit b0a2df7 into flyteorg:master Jul 8, 2020
@sbrunk sbrunk deleted the sandbox-flyte-data-config branch July 8, 2020 19:20
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Dec 6, 2022
* Using apimachinery rand and changed length to 20

Signed-off-by: Prafulla Mahindrakar <[email protected]>

* using a static start character similar to flyte-cli and flytectl

Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Changing the start character for admin generated execution names

Signed-off-by: Prafulla Mahindrakar <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Dec 20, 2022
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Aug 21, 2023
* Using apimachinery rand and changed length to 20

Signed-off-by: Prafulla Mahindrakar <[email protected]>

* using a static start character similar to flyte-cli and flytectl

Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Changing the start character for admin generated execution names

Signed-off-by: Prafulla Mahindrakar <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants