Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm notification config #2781

Merged
merged 3 commits into from
Aug 19, 2022
Merged

Fix helm notification config #2781

merged 3 commits into from
Aug 19, 2022

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Aug 18, 2022

fix: #2761

Yuvraj added 3 commits August 18, 2022 12:36
Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
Copy link
Contributor

@pmahindrakar-oss pmahindrakar-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also check the generated files for the corresponding values-eks.yaml just to confirm things look good there

@yindia yindia merged commit 55a4a64 into master Aug 19, 2022
@yindia yindia deleted the fix-helm-notification branch August 19, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Housekeeping] Helm doesn't like our notification config
4 participants