Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin][Flytekit] flytekit storage layer as plugins #809

Closed
1 of 7 tasks
tvetterli-fn opened this issue Mar 9, 2021 · 2 comments · Fixed by flyteorg/flytekit#559
Closed
1 of 7 tasks

[Plugin][Flytekit] flytekit storage layer as plugins #809

tvetterli-fn opened this issue Mar 9, 2021 · 2 comments · Fixed by flyteorg/flytekit#559
Labels
flytekit FlyteKit Python related issue
Milestone

Comments

@tvetterli-fn
Copy link

Why would this plugin be helpful to the Flyte community
When users want to connect to use gcp to store flyte workflow inputs and outputs, gsutil
has to be installed in the docker image.

It would be nice if a flytekit plugin could help us intall gsutil.

Type of Plugin

  • Python/Java interface only plugin
  • Web Service (e.g. AWS Sagemaker, GCP DataFlow, Qubole etc...)
  • Kubernetes Operator (e.g. TfOperator, SparkOperator, FlinkK8sOperator, etc...)
  • Customized Plugin using native kubernetes constructs
  • Other

Can you help us with the implementation?

  • Yes
  • No
@tvetterli-fn tvetterli-fn added the untriaged This issues has not yet been looked at by the Maintainers label Mar 9, 2021
@wild-endeavor wild-endeavor added the flytekit FlyteKit Python related issue label Mar 9, 2021
@kumare3 kumare3 changed the title [Plugin][Flytekit] [Plugin][Flytekit] flytekit storage layer as Mar 9, 2021
@kumare3 kumare3 changed the title [Plugin][Flytekit] flytekit storage layer as [Plugin][Flytekit] flytekit storage layer as plugins Mar 9, 2021
@kanterov
Copy link
Contributor

One clarification, relevant only for Python SDK. Java SDK doesn't use gsutil.

@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Mar 21, 2021
@kumare3
Copy link
Contributor

kumare3 commented Mar 21, 2021

A quick idea for the solution here,
The DataProxy object in flytekit is currently hard-coded. This can be easily converted to an extensible system using a pattern like the - https://github.com/flyteorg/flytekit/blob/master/flytekit/core/type_engine.py#L226.

This has been done for taskplugins and types in the latest flytekit and doing this will allow bringing in new implementations for similar data objects.

One of the eventual goals of the system is to use flytecopilot as the data-sidecar to handle data input and output

@kumare3 kumare3 added this to the 0.14.0 milestone May 10, 2021
@kumare3 kumare3 modified the milestones: 0.14.0, 0.15.0 Jun 2, 2021
@EngHabu EngHabu modified the milestones: 0.15.0, 0.16.0 Jul 7, 2021
@EngHabu EngHabu modified the milestones: 0.16.0, 0.17.0 Aug 2, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
…kit_plugins/greatexpectations (flyteorg#809)

Bump cookiecutter

Bumps [cookiecutter](https://github.com/cookiecutter/cookiecutter) from 1.7.3 to 2.1.1.
- [Release notes](https://github.com/cookiecutter/cookiecutter/releases)
- [Changelog](https://github.com/cookiecutter/cookiecutter/blob/master/HISTORY.md)
- [Commits](cookiecutter/cookiecutter@1.7.3...2.1.1)

---
updated-dependencies:
- dependency-name: cookiecutter
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Samhita Alla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flytekit FlyteKit Python related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants