[Housekeeping] Remove unused setting in deployment charts

[gdabisias]

Describe the issue

The deployment chart for datacatalog has the following entry for grpc-2 which is not needed and it should be removed

spec:
  {{- with .Values.datacatalog.service.type}}
  type: {{ . }}
  {{- end }}
  ports:
  - name: grpc-2
    port: 8089
    protocol: TCP
    targetPort: 8089
...
  selector: {{ include "datacatalog.selectorLabels" . | nindent 4 }}
{{- end }}

Code reference

What if we do not do this?

Nothing bad will happen, just confusing for users

Related component(s)

No response

Are you sure this issue hasn't been raised already?

• Yes

Have you read the Code of Conduct?

• Yes

[HeetVekariya]

• @gdabisias I think that issue asks to remove the following code:

- name: grpc-2
    port: 8089
    protocol: TCP
    targetPort: 8089

• If you find the solution correct, can you please assign me the issue.

[gdabisias]

@HeetVekariya yep that is the case. I can't assign things, so I'll let maintainers take it from here

[HeetVekariya]

• @gdabisias @davidmirror-ops Thank you for giving me chance to contribute. 👍
• I have made a PR, ping me if changes required.
• I just discovered that flyte is giving swags for contribution, so will get swag if this PR is merged ?

[davidmirror-ops]

@HeetVekariya 2 merged PRs will give you swag :) Checkout the process here: https://flyte.org/blog/flyte-at-hacktoberfest-2023

[HeetVekariya]

This is my first one, if possible I will make another also 👍