Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Allow no-prefix flags #341

Open
1 of 13 tasks
EngHabu opened this issue Jun 4, 2020 · 3 comments
Open
1 of 13 tasks

[Feature] Allow no-prefix flags #341

EngHabu opened this issue Jun 4, 2020 · 3 comments
Assignees
@EngHabu
Labels
enhancement New feature or request pri3 stale

Comments

@EngHabu
Copy link
Contributor

EngHabu commented Jun 4, 2020

Motivation: Why do you think this is important?
When adding config sections using flytestdlib/config, it's inconvenient to require a prefix (section name) for all Pflags added.

Goal: What should the final outcome look like, ideally?
Allow the root-level flag section to be specified without a prefix.
E.g. myCmd --option instead of myCmd --root.option

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other
@EngHabu EngHabu added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Jun 4, 2020
@EngHabu EngHabu self-assigned this Jun 4, 2020
@EngHabu EngHabu added the pri3 label Jun 4, 2020
@EngHabu EngHabu added this to the 0.8.0 milestone Jun 4, 2020
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Jun 10, 2020
@anandswaminathan anandswaminathan modified the milestones: 0.8.0, 0.9.0 Sep 30, 2020
@EngHabu EngHabu modified the milestones: 0.9.0, 0.10.0 Nov 4, 2020
@EngHabu EngHabu removed this from the 0.10.0 milestone Jan 11, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@hamersaw
Create a flyteadmin event sink filter (flyteorg#341)
0c2e586 
* moved events to top-level and merged with flyteidl events

Signed-off-by: Daniel Rammer <[email protected]>

* fixed events imports on tests

Signed-off-by: Daniel Rammer <[email protected]>

* fixed lint issues

Signed-off-by: Daniel Rammer <[email protected]>

* added error message length validation and truncating if necessary.

Signed-off-by: Daniel Rammer <[email protected]>

* fixed lint issues

Signed-off-by: Daniel Rammer <[email protected]>

* added admin event error message truncating

Signed-off-by: Daniel Rammer <[email protected]>

* began adding oppo bloom filter to admin event sink

Signed-off-by: Daniel Rammer <[email protected]>

* removed truncating error message - didn't actually fix anything

Signed-off-by: Daniel Rammer <[email protected]>

* added oppobloom filter to admin event sink

Signed-off-by: Daniel Rammer <[email protected]>

* moved EventRecorder and EventSink mocks to the mocks package

Signed-off-by: Daniel Rammer <[email protected]>

* updated tests to use fastcheck.Filter mock

Signed-off-by: Daniel Rammer <[email protected]>

* resolved merge conflicts with go.mod and go.sum

Signed-off-by: Daniel Rammer <[email protected]>

* moved idFromMessage to separate func

Signed-off-by: Daniel Rammer <[email protected]>

* updated go.mod with newest flytestdlib version to include filter mocks

Signed-off-by: Daniel Rammer <[email protected]>

* added another level of prometheus scope to better clarify metric

Signed-off-by: Daniel Rammer <[email protected]>

* exported IDFromMessage and added explicit unit tests for it

Signed-off-by: Daniel Rammer <[email protected]>

* added comment on IDFromMessage function

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@cosmicBboy
update doc requirements with sphinx v4 (flyteorg#341)
4a77808 
Signed-off-by: cosmicBboy <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@katrogan
Update flyteidl version (flyteorg#341)
5ce4e90 
Signed-off-by: Katrina Rogan <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@ByronHsu
Pass worker_spec_command to mpi plugin to support horovod (flyteorg…
46796b6 
…#341)

* wip

Signed-off-by: byhsu <[email protected]>

* add comment

Signed-off-by: byhsu <[email protected]>

* more comment

Signed-off-by: byhsu <[email protected]>

* fix style

Signed-off-by: byhsu <[email protected]>

---------

Signed-off-by: byhsu <[email protected]>
Co-authored-by: byhsu <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@hamersaw
Create a flyteadmin event sink filter (flyteorg#341)
7b09010 
* moved events to top-level and merged with flyteidl events

Signed-off-by: Daniel Rammer <[email protected]>

* fixed events imports on tests

Signed-off-by: Daniel Rammer <[email protected]>

* fixed lint issues

Signed-off-by: Daniel Rammer <[email protected]>

* added error message length validation and truncating if necessary.

Signed-off-by: Daniel Rammer <[email protected]>

* fixed lint issues

Signed-off-by: Daniel Rammer <[email protected]>

* added admin event error message truncating

Signed-off-by: Daniel Rammer <[email protected]>

* began adding oppo bloom filter to admin event sink

Signed-off-by: Daniel Rammer <[email protected]>

* removed truncating error message - didn't actually fix anything

Signed-off-by: Daniel Rammer <[email protected]>

* added oppobloom filter to admin event sink

Signed-off-by: Daniel Rammer <[email protected]>

* moved EventRecorder and EventSink mocks to the mocks package

Signed-off-by: Daniel Rammer <[email protected]>

* updated tests to use fastcheck.Filter mock

Signed-off-by: Daniel Rammer <[email protected]>

* resolved merge conflicts with go.mod and go.sum

Signed-off-by: Daniel Rammer <[email protected]>

* moved idFromMessage to separate func

Signed-off-by: Daniel Rammer <[email protected]>

* updated go.mod with newest flytestdlib version to include filter mocks

Signed-off-by: Daniel Rammer <[email protected]>

* added another level of prometheus scope to better clarify metric

Signed-off-by: Daniel Rammer <[email protected]>

* exported IDFromMessage and added explicit unit tests for it

Signed-off-by: Daniel Rammer <[email protected]>

* added comment on IDFromMessage function

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@ByronHsu
Pass worker_spec_command to mpi plugin to support horovod (flyteorg…
287b295 
…#341)

* wip

Signed-off-by: byhsu <[email protected]>

* add comment

Signed-off-by: byhsu <[email protected]>

* more comment

Signed-off-by: byhsu <[email protected]>

* fix style

Signed-off-by: byhsu <[email protected]>

---------

Signed-off-by: byhsu <[email protected]>
Co-authored-by: byhsu <[email protected]>
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 3, 2023
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@katrogan
Update flyteidl version (flyteorg#341)
ae1f5c0 
Signed-off-by: Katrina Rogan <[email protected]>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@katrogan @austin362667
Update flyteidl version (flyteorg#341)
885eea9 
Signed-off-by: Katrina Rogan <[email protected]>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@katrogan @robert-ulbrich-mercedes-benz
Update flyteidl version (flyteorg#341)
c569038 
Signed-off-by: Katrina Rogan <[email protected]>
troychiu pushed a commit that referenced this issue Jul 8, 2024
@hamersaw
Add components for Actor ID uniqeness (#341)
964421b 
## Overview
This PR adds components to ensure each Actor Environment is unique. The attribute list is org, project, domain, a user provided ID, and an auto-generate version hash.

## Test Plan
This will be tested locally under a variety of scenarios. This change only affects which fasttasks are executed in each environment, so there is no need for testing on Union.

## Rollout Plan (if applicable)
Once validated this update may be  deployed to all tenants immediately.

## Upstream Changes
Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F).
- [ ] To be upstreamed to OSS

## Issue
https://linear.app/unionai/issue/EXO-110/decide-on-execution-environment-id-uniqueness-for-actor-environments

## Checklist
* [ ] Added tests
* [ ] Ran a deploy dry run and shared the terraform plan
* [ ] Added logging and metrics
* [ ] Updated [dashboards](https://unionai.grafana.net/dashboards) and [alerts](https://unionai.grafana.net/alerting/list)
* [ ] Updated documentation
@github-actions GitHub Actions
Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EngHabu EngHabu

Labels
enhancement New feature or request pri3 stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@EngHabu @eapolinario @kumare3 @anandswaminathan