[copilot] rename sidecar to uploader (#6043)

* rename all occurences Signed-off-by: wayner0628 <[email protected]> * Revert Signed-off-by: wayner0628 <[email protected]> * rename upload container Signed-off-by: wayner0628 <[email protected]> * add test Signed-off-by: wayner0628 <[email protected]> --------- Signed-off-by: wayner0628 <[email protected]>
flyteorg · Dec 2, 2024 · 34e48d5 · 34e48d5
1 parent ab0132e
commit 34e48d5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/flyteplugins/go/tasks/pluginmachinery/flytek8s/copilot.go b/flyteplugins/go/tasks/pluginmachinery/flytek8s/copilot.go
@@ -20,7 +20,7 @@ import (
 )
 
 const (
-	flyteSidecarContainerName = "sidecar"
+	flyteSidecarContainerName = "uploader"
 	flyteInitContainerName    = "downloader"
 )
 

diff --git a/flyteplugins/go/tasks/pluginmachinery/flytek8s/copilot_test.go b/flyteplugins/go/tasks/pluginmachinery/flytek8s/copilot_test.go
@@ -4,6 +4,7 @@ import (
 	"context"
 	"encoding/base64"
 	"reflect"
+	"strings"
 	"testing"
 	"time"
 
@@ -107,6 +108,12 @@ func TestFlyteCoPilotContainer(t *testing.T) {
 		assert.Error(t, err)
 		cfg.Memory = old
 	})
+
+	t.Run("sidecar-container-name-change", func(t *testing.T) {
+		c, err := FlyteCoPilotContainer(flyteSidecarContainerName, cfg, []string{"hello"})
+		assert.NoError(t, err)
+		assert.Equal(t, "uploader", strings.Split(c.Name, "-")[1])
+	})
 }
 
 func TestDownloadCommandArgs(t *testing.T) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -20,7 +20,7 @@ import ( @@
     )
     const (
-    	flyteSidecarContainerName = "sidecar"
+    	flyteSidecarContainerName = "uploader"
     	flyteInitContainerName    = "downloader"
     )
@@ Expand Down @@