Skip to content

Commit

Permalink
persist abort state on NodePhaseTimingOut
Browse files Browse the repository at this point in the history
Signed-off-by: Paul Dittamo <[email protected]>
  • Loading branch information
pvditt committed Jan 23, 2024
1 parent 542c4aa commit 1172ef6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion flytepropeller/pkg/controller/nodes/executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -1341,7 +1341,7 @@ func (c *nodeExecutor) HandleNode(ctx context.Context, dag executors.DAGStructur

if currentPhase == v1alpha1.NodePhaseTimingOut {
logger.Debugf(ctx, "node timing out")
if err := c.Abort(ctx, h, nCtx, "node timed out", false); err != nil {
if err := c.Abort(ctx, h, nCtx, "node timed out", true); err != nil {

Check warning on line 1344 in flytepropeller/pkg/controller/nodes/executor.go

View check run for this annotation

Codecov / codecov/patch

flytepropeller/pkg/controller/nodes/executor.go#L1344

Added line #L1344 was not covered by tests
return interfaces.NodeStatusUndefined, err
}

Expand Down

0 comments on commit 1172ef6

Please sign in to comment.