nit

Signed-off-by: Kevin Su <[email protected]>
flyteorg · Jul 16, 2024 · 0ae89ac · 0ae89ac
1 parent 27a350c
commit 0ae89ac
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/flyteplugins/go/tasks/plugins/testing/echo.go b/flyteplugins/go/tasks/plugins/testing/echo.go
@@ -32,6 +32,8 @@ func (e *EchoPlugin) GetProperties() core.PluginProperties {
 	return core.PluginProperties{}
 }
 
+// Enqueue the task to be re-evaluated after SleepDuration.
+// If the task is already enqueued, return the start time of the task.
 func (e *EchoPlugin) addTask(ctx context.Context, tCtx core.TaskExecutionContext) time.Time {
 	e.Lock()
 	defer e.Unlock()
@@ -54,6 +56,7 @@ func (e *EchoPlugin) addTask(ctx context.Context, tCtx core.TaskExecutionContext
 	return startTime
 }
 
+// Remove the task from the taskStartTimes map.
 func (e *EchoPlugin) removeTask(taskExecutionID string) {
 	e.Lock()
 	defer e.Unlock()
@@ -86,6 +89,7 @@ func (e *EchoPlugin) Finalize(ctx context.Context, tCtx core.TaskExecutionContex
 	return nil
 }
 
+// copyInputsToOutputs copies the input literals to the output location.
 func copyInputsToOutputs(ctx context.Context, tCtx core.TaskExecutionContext) (core.Transition, error) {
 	inputToOutputVariableMappings, err := compileInputToOutputVariableMappings(ctx, tCtx)
 	if err != nil {

diff --git a/flytepropeller/pkg/controller/nodes/branch/handler.go b/flytepropeller/pkg/controller/nodes/branch/handler.go
@@ -152,7 +152,6 @@ func (b *branchHandler) recurseDownstream(ctx context.Context, nCtx interfaces.N
 
 	if downstreamStatus.IsComplete() {
 		// For branch node we set the output node to be the same as the child nodes output
-		nCtx.NodeStateWriter()
 		phase := handler.PhaseInfoSuccess(&handler.ExecutionInfo{
 			OutputInfo: &handler.OutputInfo{OutputURI: v1alpha1.GetOutputsFile(childNodeStatus.GetOutputDir())},
 		})