Enable Linux compilable support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hide array as implementation detail in shared function.
Use more variables to have more readable makefile. Also easier to specify custom values this way.
Try to make using upstream easier.
Is failing on startup anyway, but at least compiles.
It starts, but still is not usable.
It seems unsigned long for pixels were used by mistake and later corrected in stb_image routines. But is still used in custom code. Declare special type for representing TexPixel to make it more obvious size is used for pixels in texture.
Similar issue which was met on endless-sky game. Fedora may prefer wayland and emit glewInit() failure, but otherwise it is initialized correctly. Detect that case and pass into the application. It should work if SDL were correctly initialized. Glut does not seem to be needed for anything in this case. More on: endless-sky/endless-sky#7027
It seems after changes GLee is no longer useful for anything. The same with freeglut. It is not needed for anything. SDL2 should handle it completely.
Few unimportant changes to formatting or debugging, without significant functionality changes.
Add support definitions for tinyxml 2.6, but keep backward compatibility of bundled tinyxml version bundled inside. Allows building both with bundled and system tinyxml library.
Just hide the warning it emits.
Keep bundled version intact for use on Windows, but allow simple switching to bundled library. Do not compile bundled tinyxml by default. Comment out tinyxml-src reset to empty value to restore building.
|
Unfortunately build support for Linux binary is not sufficient for adding this to Linux distributions. Data required to run this program were never put into original repository with clearly specified license. So distributions ensuring only free software can be shipped cannot contain this program in current state. At least not in official distribution channels. Clearly not passing Fedora licensing requirements, but otherwise works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications to makefile to make it buildable again on Linux. Reuses SDL2 changes and enables them also on Linux distribution.
Use extensive use of pkg-config instead of old fixed paths in various places. Reworks parts of shared headers, but should keep existing Windows support unharmed. While enabling also building on Linux with GNU make. Should make it more flexible and compilable on various distributions. I have made it working on Fedora 39, but should work also on recent Ubuntu or Debian.