This repository has been archived by the owner on Nov 8, 2017. It is now read-only.
executor: Improve error handling #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvatic
force-pushed
the
better-error-handling
branch
2 times, most recently
from
a190581 to
66ec6ba
Compare
jvatic
commented
Oct 11, 2016
- Don't use panic/recover to propagate errors - Return immediately when an error occurs - Execute request fields in deterministic order Signed-off-by: Jesse Stuart <[email protected]>
jvatic
force-pushed
the
better-error-handling
branch
from
66ec6ba to
137ddfa
Compare
jvatic
changed the title
jvatic
commented
Oct 12, 2016
titanous
approved these changes
Oct 13, 2016
Signed-off-by: Jesse Stuart <[email protected]>
titanous
approved these changes
Oct 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\cc @titanous