Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACME: use HTTP for the Nginx readyness check #595

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

dpausp
Copy link
Member

@dpausp dpausp commented Jun 12, 2020

This avoids conflicts with other services that want to use port 443.
Our current use case for this is a TURN server using 443.
Nginx can be configured to only listen on port 80 now.
The acme client uses HTTP for challenges.

Case 126629

@flyingcircusio/release-managers

Release process

Impact:

Changelog:

  • Fix port conflict on 443 when Letsencrypt is used. This makes it possible to run a TURN server on 443 with automated letsencrypt certs, for example.

Security implications

  • Security requirements defined? (WHERE)
    • only affects an internal check on a port that must be open anyways for letsencrypt
  • Security requirements tested? (EVIDENCE)
    - nothing to test

This avoids conflicts with other services that want to use port 443.
Our current use case for this is a TURN server using 443.
Nginx can be configured to only listen on port 80 now.
The acme client uses HTTP for challenges.

Case 126629
@ckauhaus ckauhaus merged commit 2782498 into nixos-19.03 Jun 12, 2020
@ckauhaus ckauhaus deleted the 126629-acme-avoid-443-conflict branch June 12, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants