Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.05] move backy to nixpkgs-23.05 #798

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

dhnasa
Copy link
Collaborator

@dhnasa dhnasa commented Oct 2, 2023

removes nixpkgs-22.11
depends on flyingcircusio/backy#54
backy diff: https://github.com/flyingcircusio/backy/compare/5fa55f0c512e557bea3802f0be10e997e6f33f03..e37a7f6570b6b9194cb3a27d8db2951eb5c992ce

PL-131758, PL-131607
@flyingcircusio/release-managers

Release process

Impact: internal

Changelog:

  • A number of bugfixes and improvements to our backup utility (backy)

    • consistency check improvements (automatic distrust on verification failures, improved lock handling, quarantining of inconsistent chunks)
    • fix service reload inconsistencies and crashes
    • remove outdated, unused code and features
    • fix a crash when parent pointers were incomplete and the immediate parent was missing its snapshot
    • Add nix flake support

Security implications

  • Security requirements defined? (WHERE)
    • keep software up to date
  • Security requirements tested? (EVIDENCE)
    • verify this builds and backups still work in dev environment
    • automated hydra tests still pass

@ctheune ctheune self-assigned this Oct 11, 2023
@ctheune ctheune marked this pull request as ready for review October 11, 2023 14:01
Copy link
Member

@ctheune ctheune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I reviewed the actual release already.

@ctheune ctheune force-pushed the PL-131758-move-backy-to-23.05 branch from 55136e5 to 603dfa6 Compare October 12, 2023 11:59
@ctheune ctheune marked this pull request as draft October 12, 2023 12:10
@ctheune
Copy link
Member

ctheune commented Oct 12, 2023

We just updated this to 2.5.1 to fix the "jobs" command. However, we found a weird inconsistency on the development backy server where backups where continuously failing with wrong data in the validation phase.

@ctheune
Copy link
Member

ctheune commented Oct 19, 2023

I revisited this on patty and the only job that showed signs of failure is back to normal. My thought here is that we ended up in a weird situation after I used patty for different work-in-progress states and might have ended up confusing this one job.

@ctheune ctheune marked this pull request as ready for review October 19, 2023 12:19
@ctheune ctheune merged commit 99716ee into fc-21.05-dev Oct 19, 2023
1 check passed
@ctheune ctheune deleted the PL-131758-move-backy-to-23.05 branch October 19, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants