Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] remove unused release code #1224

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

dhnasa
Copy link
Collaborator

@dhnasa dhnasa commented Jan 8, 2025

PL-133179

this is now managed by fc-nixos-release-tools

@flyingcircusio/release-managers

Release process

  • Created changelog entry using ./changelog.sh
    • n/a

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

this is now managed by fc-nixos-release-tools
@dhnasa dhnasa changed the title remove unused release code [24.05] remove unused release code Jan 8, 2025
@ctheune ctheune merged commit d50d607 into fc-24.05-dev Jan 8, 2025
2 checks passed
@ctheune ctheune deleted the PL-133179-remove-scriv-24.05 branch January 8, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants