Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update-nixpkgs cleanup action #1186

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

leona-ya
Copy link
Member

@leona-ya leona-ya commented Dec 4, 2024

This action is part of the update-nixpkgs workflow in fc-nixos-release-tools.

Important

This requires flyingcircusio/fc-nixos-release-tools#2 to be merged first.

PL-133100

@flyingcircusio/release-managers

Release process

  • Created changelog entry using ./changelog.sh

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

This action is part of the update-nixpkgs workflow in fc-nixos-release-tools.
It requires access to this repository's events, so it needs to be located here.

PL-133100
@ctheune
Copy link
Member

ctheune commented Dec 4, 2024

Well the security should also be: doesn't screw things up and doesn't pull in unwanted code from somewhere ... ;)

@ctheune ctheune merged commit b085e0d into fc-24.05-dev Dec 4, 2024
2 checks passed
@ctheune ctheune deleted the PL-133100-update-nixpkgs branch December 4, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants