Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3 management: add user management #1167

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Conversation

ctheune
Copy link
Member

@ctheune ctheune commented Nov 14, 2024

  • accounting now uses the command runner utility code

  • s3 users are now managed (created, deleted and updated)

Re PL-133084

@flyingcircusio/release-managers

Release process

  • Created changelog entry using ./changelog.sh

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.

nope

  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

yeah, this is still needed

Security implications

mostly data consistency, specifically: avoid deleting customer data. we do this by leveraging the 'staged deletion' procotol with prepare/soft/hard tombstones.

  • Security requirements tested? (EVIDENCE)

added automated tests and performed manual tests

@osnyx
Copy link
Member

osnyx commented Nov 27, 2024

tests.kvm_host_ceph-nautilus-nautilus is failing reproducibly.

osnyx and others added 4 commits December 2, 2024 14:19
- accounting now uses the command runner utility code

- s3 users are now managed (created, deleted and updated)

Re PL-133084
We decided to simplify the directory API as we do not have a specific
use case to let storage servers discover S3 users from other clusters.

This is due to the caution to not accidentally end up deleting data
for a user in the local cluster just because someone wanted to delete
a user in a foreign cluster and due to simple bugs we end up seeing this
in the wrong cluster and act on it.
@ctheune ctheune force-pushed the PL-133084-s3-usermgmt branch from 6342f7c to d2b848b Compare December 3, 2024 08:23
@ctheune ctheune merged commit 8d36eab into fc-21.05-dev Dec 3, 2024
2 checks passed
@ctheune ctheune deleted the PL-133084-s3-usermgmt branch December 3, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants