-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PL-133007] implement the D(HE)at Attack mitigation #1162
Conversation
|
||
### NixOS XX.XX platform | ||
|
||
- restrict the Diffie-Hellman elliptic curves offered by Nginx to mitigate CVE-2024-41996 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include which exact curve is disabled, such that customers can determine whether they're affected or not from changelog information alone.
a9eeb51
to
87e1ec4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, but I'd like to see a changelog entry that's more suitable for people not as deep into the context as we are. ;)
changelog.d/20241112_110807_phil-PL-133007_nginx-dheat-mitigation_scriv.md
Outdated
Show resolved
Hide resolved
87e1ec4
to
1fb65b8
Compare
I hope this wording makes more sense to non-technical people. Cryptography has a tendency of being quite tough to explain IME |
Since restricting encryption curves might impact compatibility with various clients, this was made an option for now with the default being on so that it can be turned off selectively.
1fb65b8
to
5e96656
Compare
rebased onto fc-24.05-dev, hoping this fixes the gitlab test. |
Suggested changes have been implemented.
mitigate CVE-2024-41996
Since restricting encryption curves might impact compatibility with various clients, this was made an option for now with the default being on so that it can be turned off selectively.
@flyingcircusio/release-managers
Release process
./changelog.sh
PR release workflow (internal)
Design notes
on
oroff
. Example: rate limiting.Security implications
without the patch
with the patch
see also the internal ticket for a more detailed writeup