Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05][PL-133119] release: use globs for constituents #1152

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 6, 2024

PL-133119

@flyingcircusio/release-managers

Release process

  • Created changelog entry using ./changelog.sh

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    Release job must await all other jobs to pass.
  • Security requirements tested? (EVIDENCE)
    Confirmed on Staging Hydra.

@Ma27 Ma27 changed the title [PL-133119] release: use globs for constituents [24.05][PL-133119] release: use globs for constituents Nov 6, 2024
@Ma27 Ma27 requested a review from ctheune November 6, 2024 13:11
@ctheune ctheune merged commit 2cd50af into fc-24.05-dev Nov 6, 2024
1 check passed
@ctheune ctheune deleted the PL-133119-constituent-globbing-2405 branch November 6, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants