Added a "skip http headers" option #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it was ambiguous because the output for the tag was empty.
This also removes the custom javascript used to extract bullet info from the headers in ajax requests.
iainbeeston
force-pushed
the
skip-http-headers
branch
from
f090ccd to
ef00b6b
Compare
|
@flyerhzm Is it possible to release a new version of the gem that includes this change? |
|
@iainbeeston I have released version 6.1.4 |
|
Thank you! 🙂 |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if the console or footer options are enabled, then API requests will include extra headers for bullet. These only exist to power the XHR script that's included in HTML pages, which are irrelevant to an API request. At the moment there's no way to disable this, so I've added a new option for it. Because disabling these headers prevents the XHR javascript hooks from working, I've also made the new option prevent the XHR javascript from being added to pages.
As part of this I cleaned up a handful of related tests that test existing behaviour, so I've put those changes in a separate commit.