Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for yamllint #1640

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Conversation

krzysztof-magosa
Copy link
Contributor

This PR adds yaml-yamllint plugin (https://github.com/krzysztof-magosa/flycheck-yamllint/issues) to base flycheck code.

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@cpitclaudel cpitclaudel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few things to discuss.

@krzysztof-magosa krzysztof-magosa force-pushed the yamllint branch 4 times, most recently from 5c2bdc8 to c0b515c Compare October 27, 2019 16:17
@krzysztof-magosa
Copy link
Contributor Author

@cpitclaudel I hope it looks correct now, please re-review.

@krzysztof-magosa
Copy link
Contributor Author

I hope that's all ;)

@cpitclaudel cpitclaudel merged commit e55a361 into flycheck:master Oct 28, 2019
@cpitclaudel
Copy link
Member

Indeed it is! Thanks a lot :)

@krzysztof-magosa krzysztof-magosa deleted the yamllint branch October 29, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants