Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: coerce troubleshooting logs to strings #9794

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

tracernz
Copy link
Member

Fixes #[issue_no]

Summary of Changes

Always coerce the error to a string before it gets serialised, to ensure we get exception messages in the log.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@tracernz tracernz added this to the v0.13.0 milestone Jan 22, 2025
@tracernz tracernz enabled auto-merge (squash) January 22, 2025 09:08
@tracernz tracernz merged commit 8124e27 into flybywiresim:master Jan 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

2 participants