Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x/eng): Display simple oil quantity estimation #9785

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Jan 19, 2025

Fixes #9258

Summary of Changes

We already have a very simple estimation of oil quantity, this displays it on the SD ENG page.
To be replaced by better simulation once we have a new engine model.
Used old code, ported it.

Screenshots (if necessary)

image

References

References for RR Trent 900 max. oil quantity surprisingly hard to find.
image
https://youtu.be/p28erS6uWHE?si=80yzzw8NgSvWhmzw&t=1869

Additional context

Discord username (if different from GitHub): floridude

Testing instructions

Perform cold&dark startup, take-off, fly around a bit, engine should perform without problems (oil qty and oil temp should not be zero, oil temp doesn't make sense still)

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@flogross89 flogross89 added QA Not Required A380X Related to the A380X aircraft labels Jan 19, 2025
@flogross89 flogross89 added this to the v0.13.0 milestone Jan 19, 2025
@flogross89 flogross89 marked this pull request as draft January 19, 2025 02:27
@flogross89 flogross89 marked this pull request as ready for review January 19, 2025 13:14
@flogross89 flogross89 added QA A380 Only QA only for A380 required Engines Anything related to engines. (ata-72) and removed QA Not Required labels Jan 19, 2025
@flogross89 flogross89 requested a review from tracernz January 20, 2025 00:59
@flogross89
Copy link
Contributor Author

flogross89 commented Jan 20, 2025

Quality Assurance Report

Discord Username : floridude
Object of testing : #9785
Aircraft : A380X
Tier of Testing : 1
Date : 20/01/2025

Testing Process:
Load cold&dark, start engines, take-off, fly for ca. one hour and verify engine parameters are as expected.

Oil quantity: Initialized with random deviations, also readable before engine start when powering FADECs, oil gulp seems plausible. During climb, quantity remains >13 qt

Oil temperature: Initialized with ambient temperature, rises to 85 deg after engine start and remains there until climb, decreased to around 75 °C during cruise. Not too plausible (too high), but I'll take it.

Oil pressure: Remained below 100 PSI, no references known but seems plausible given the overall state of the engine model.

Shortly after take-off:
image

Climb, FL270:
image

Cruise FL400:
image

Open descend (idle thrust):
image

Testing Results:
Passed

@flogross89 flogross89 enabled auto-merge (squash) January 20, 2025 13:37
@flogross89 flogross89 merged commit 8f33f63 into flybywiresim:master Jan 20, 2025
8 checks passed
@flogross89 flogross89 deleted the feat-a380x-oil-qty branch January 24, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft Engines Anything related to engines. (ata-72) QA A380 Only QA only for A380 required QA Passed
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

Oil Qty is 0
2 participants