Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380x/fws): Automatic normal checklist reset #9614

Merged
merged 11 commits into from
Dec 29, 2024

Conversation

BravoMike99
Copy link
Contributor

@BravoMike99 BravoMike99 commented Dec 1, 2024

Fixes #[issue_no]

Summary of Changes

Adds automatic reset of normal checklists on powerup, go around & after shutdown.
Fixes NO MOBILE memo visibility due to new checklist style (no longer inhibited due to takeoff/ldg memos).
Changes FWS startup/shutdown to take into account the correct power source (DC ESS on A380 for FWS 1)

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):
bruno_pt99

Testing instructions

  1. Complete some normal checklists on the EWD of your choice. Completely power down the aircraft and then power it up again. Verify all previous ECL checklists are no longer completed.
  2. Complete the approach & landing checklist alongside some others of your choice located before the approach checklist . Once below 1500FT RA perform a normal go around.
  3. Verify that all the previous completed checklists located after the "DEPARTURE CHANGE" have been reset.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@BravoMike99 BravoMike99 added FWS Flight Warning Computer (ata-31) A380X Related to the A380X aircraft labels Dec 1, 2024
Copy link
Contributor

@flogross89 flogross89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one, thanks! With this, we could even have a functional C/B reset for the FWS right now 😀

@BravoMike99
Copy link
Contributor Author

Good one, thanks! With this, we could even have a functional C/B reset for the FWS right now 😀

We'd probably need to completely stop the FWS execution & reset the data when its unpowered/off before that can be the case 😅 Right now it would only reset the normal checklists.

@alexr4339
Copy link

alexr4339 commented Dec 29, 2024

Quality Assurance Tester Report

Discord Username : alexdnzdmb
Object of testing : #9614
Aircraft : A380X
Tier of Testing : 1
Date : 29/12/2024

Testing Process:
Complete some normal checklists on the EWD of your choice. Completely power down the aircraft and then power it up again. Verify all previous ECL checklists are no longer completed. - Check

Complete the approach & landing checklist alongside some others of your choice located before the approach checklist . Once below 1500FT RA perform a normal go around. - Check

Verify that all the previous completed checklists located after the "DEPARTURE CHANGE" have been reset. - Check

Testing Results:
Passed

Negatives:

Conclusions:

Media:

@BravoMike99 BravoMike99 enabled auto-merge (squash) December 29, 2024 10:41
@BravoMike99 BravoMike99 merged commit 3bf1438 into flybywiresim:master Dec 29, 2024
8 checks passed
denmax18 added a commit to denmax18/A388x that referenced this pull request Dec 29, 2024
Saschl pushed a commit to Saschl/a32nx that referenced this pull request Jan 2, 2025
* fix fws: no mobile memo visiblity

* feat: fws reset normal checklists on power up.

* cleanup abnormal sensed debug info

* feat (fws): add reset of CL after shutdown & on GA

* fix: remove flightphase inhibit of no mobile

* docs: update changelog

* fix: use departure change id as starting point after GA

* docs: improve changelog wording

* fix fwc phase merge conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft FWS Flight Warning Computer (ata-31) QA Passed QA Ready to Test QA Tier 1
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

3 participants