-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a380x/flightmodel): adjust climb performance #9358
fix(a380x/flightmodel): adjust climb performance #9358
Conversation
Tested some of the values you've amended the plane feels a bit sluggish at climb now. Gross weight of about 373tonnes and my climb was only 2000fpm during the climb from 10000feet to 15000feet with IAS 290knots on open climb. This value was more believable if the gross weight was around 500tonnes or more. |
Thanks for testing! I noticed the same thing indeed, this was due to an error in my tuning method. I will continue to work on it. |
d92d0d4
to
9663561
Compare
@BlueberryKing Let me know when you are done so we can do a formal code review Also changelog needed. |
Has the parameters been tested and merged with the supposed Another taxi thrust adjustment Cause i seem to see both pulls involve the same cfg. |
c66689a
to
bedbcf8
Compare
My changes are now on top of the PR you mention, so they shouldn't conflict. |
734f0c4
to
766d387
Compare
One test here and it looked very good to me. Although I don't have any data to base it on (other than comparison to the A32NX), the climb rates looked very believable. For my flight, FMS predicted FL 400 at REC MAX, and I got to FL 39.6 before the climb rate stayed below 300 fpm (one definition of REC MAX). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, thank you!
fbw-a32nx/src/systems/fmgc/src/guidance/vnav/climb/ClimbPathBuilder.ts
Outdated
Show resolved
Hide resolved
Thank you for the reviews! I will address your comments as soon as I can. |
This comment was marked as off-topic.
This comment was marked as off-topic.
766d387
to
3853f95
Compare
This PR does not affect taxi thrust. Taxi thrust has already been adjusted with the assistance of IRL A380 pilots on the team. (The THR indication on the A380X is not accurately modeled yet.) |
b5ccf0d
to
163cbb6
Compare
I have made some further adjustments to the thrust output and thrust limits. The thrust output might be a bit too high at high altitudes now, but I prefer that for this initial adjustment PR. Feel free to give it a test! |
Quality Assurance Tester Report Discord Username : alexdnzdmb Testing Process: Flight 1: THR IDLE DES Testing Results: Negatives: Conclusions: Media: |
Quality Assurance Tester Trainee Report Discord Username : Matt Testing Process: Notes: Various takeoffs and climbs at light and heavy weights. I think this feels as much like an a380 now as I can tell, without jumping in an FMS and doing a direct comparison. I think it is close enough that it feels right. Acknowledged about the THR vs N1 discussion and derates. However, as an interim before they are addressed, I think it feels really good. I would say this QA passed. |
* Adjust climb performance * Tune to drag coefficient 1 * Adjust REC MAX altitude * Make engine performance table aircraft-specific * Fix incorrect arguments being passed * Try adjusting to in-sim tests * Merge with taxi thrust adjustment * Add changelog * Make flight model aircraft-specific * Fix typo * Add changelog * Fix changelog * Increase thrust limits * Increase high-mach thrust * Separate thrust limit between aircraft * Increase thrust limits around FL300 * Increase high-mach thrust after feedback * Increase thrust
Fixes #9042
Summary of Changes
Tune engine thrust and drag model to be more accurate.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.