Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make datastorage aircraft specific #9116

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

Saschl
Copy link
Contributor

@Saschl Saschl commented Oct 21, 2024

Fixes #[issue_no]

Summary of Changes

  • We need to distinguish between A380 and A320 properties. Using the project-prefix env variable to achieve this.
  • Cleanup of some legacy usages of shared code, which was moved to fbw-common (including persistence)

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

In the A380X:

  1. Load in the plane, change some configuration options in the EFB.
    Some examples (best to test as much as possible):
    1. Enter override user for simbrief and import a flight plan
    2. Navigraph login, oans, simbrief, charts, (DM me for build with the secrets enabled if you wish to test this)
    3. Telex, simbridge port and connection, volume sliders, acceleration height...
    4. display self-test time
    5. efis sync
  2. Restart the flight and ensure the properties are saved and have not changed from what you've entered
  3. Perform a flight ideally

In the A320:

  1. Take the examples (and more if you wish) from above and note down the values you have configured BEFORE using this PR
  2. Download the PR and verify the settings did not change
  3. Verify the settings are applied correctly after loading (check efis sync, kg/lbs, accel height for example).
  4. Change some values and verify they are applied properly (like in 3. for example)
  5. Perform a flight ideally

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@Saschl Saschl marked this pull request as ready for review October 21, 2024 21:16
@Saschl Saschl added Not Ready For Review Still draft but needs a GitHub build and removed Not Ready For Review Still draft but needs a GitHub build labels Oct 21, 2024
@flogross89 flogross89 added Showstopper this issue is blocking the next stable release A380X Related to the A380X aircraft A32NX Related to the A32NX aircraft labels Oct 21, 2024
@Saschl
Copy link
Contributor Author

Saschl commented Oct 22, 2024

Did some initial checks on the A320.

State before the PR:

Screenshot 2024-10-22 094926
Screenshot 2024-10-22 094901
Screenshot 2024-10-22 094855
Screenshot 2024-10-22 094759
Screenshot 2024-10-22 094747

After restart with the PR:

Screenshot 2024-10-22 101210

Screenshot 2024-10-22 101243
Screenshot 2024-10-22 101231
Screenshot 2024-10-22 101222

Navigraph was still logged in. Simbrief import worked on EFB and FMS. Changed several options in the EFB (simbridge connection on/off to test the triggers, Accel height). All were applied correctly.

Screenshot 2024-10-22 101813

Screenshot 2024-10-22 101819

@tylerclt
Copy link

Quality Assurance Tester/Trainee Report

Discord Username: tylerb780
Object of testing : #9116
Aircraft: A32NX
Tier of Testing: 1
Date: 22/10/2024

Testing Process:

  1. Loaded into KTEX on the runway
  2. Turned on FlyPad
  3. Noted settings before PR
  4. Installed the PR
  5. Re-loaded into KTEX on the runway
  6. Verified settings and other values did not change.

Testing Results:
Passed

Conclusions:
Working as intended

Media:
Before the PR:
1250410_20241022165714_1 - Copy
1250410_20241022165708_1 - Copy
1250410_20241022165705_1 - Copy
1250410_20241022165700_1 - Copy
1250410_20241022165654_1 - Copy
1250410_20241022165647_1 - Copy
After the PR:
1250410_20241022172153_1
1250410_20241022172148_1
1250410_20241022172143_1
1250410_20241022172138_1
1250410_20241022172133_1
1250410_20241022172128_1
1250410_20241022172125_1
1250410_20241022165719_1

@Popespice
Copy link

Popespice commented Oct 22, 2024

Quality Assurance Tester Report

Discord Username : popespice
Object of testing : #9116
Aircraft : A380x
Tier of Testing : 1
Date : 22102024

Testing Process:

  1. Load into the sim
  2. Power on plane as normal
  3. Load navigraph User ID and login
  4. Test OANS, Test Charts
  5. Observe all navigraph based A380 functions work as expected

Testing Results:
Passed

Negatives:
N/A

Conclusions:
Working as expected

@Saschl Saschl enabled auto-merge (squash) October 22, 2024 22:38
@Saschl Saschl merged commit 8c58f8b into flybywiresim:master Oct 22, 2024
7 checks passed
flogross89 pushed a commit that referenced this pull request Oct 22, 2024
* fix: make datastorage aircraft specific

* fix: remove usages of legacy persistence.ts

* use common name for datastore update event

(cherry picked from commit 8c58f8b)
@flogross89 flogross89 added this to the v0.12.0 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft QA Passed QA Ready to Test QA Tier 1 Showstopper this issue is blocking the next stable release
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

6 participants