-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a380x/SD): Hook up door SD page to door status #9077
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BravoMike99
force-pushed
the
fix-door-sd
branch
from
October 16, 2024 18:19
786e0d7
to
ab25a56
Compare
Benjozork
reviewed
Oct 16, 2024
const CargoDoor: React.FC<Position & CargoDoorProps> = ({ x, y, label, width, height, engineRunning }) => { | ||
const doorOpen = false; | ||
const CargoDoor: React.FC<Position & CargoDoorProps> = ({ x, y, label, identifier, width, height, engineRunning }) => { | ||
const doorOpen = identifier ? !useSimVar(`L:A32NX_${identifier}_DOOR_CARGO_LOCKED`, 'bool', 1000)[0] : false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: React hooks should not be called conditionally.
2hwk
approved these changes
Oct 19, 2024
2hwk
added
A380X
Related to the A380X aircraft
QA A380 Only
QA only for A380 required
QA Tier 1
QA Ready to Test
labels
Oct 19, 2024
Quality Assurance Report Discord Username : 2cas Testing Process:
Negatives:
Testing Results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A380X
Related to the A380X aircraft
QA A380 Only
QA only for A380 required
QA Passed
QA Ready to Test
QA Tier 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8996
Summary of Changes
Hooks up the door SD page to door status & fixes the positioning of the door open text.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
bruno_pt99
Testing instructions
Popup the DOOR SD page on the lower ecam.
Open a main door and a cargo door of your choice through the EFB. The associated door icon should show as amber on the DOOR SD page.
Turn the beacon light on. "S" should appear next to the closed main doors.
Start an engine, once the engine is running a yellow amber text should appear next to the open doors.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.