Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x/SD): Hook up door SD page to door status #9077

Merged
merged 7 commits into from
Oct 20, 2024

Conversation

BravoMike99
Copy link
Contributor

Fixes #8996

Summary of Changes

Hooks up the door SD page to door status & fixes the positioning of the door open text.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):
bruno_pt99

Testing instructions

Popup the DOOR SD page on the lower ecam.
Open a main door and a cargo door of your choice through the EFB. The associated door icon should show as amber on the DOOR SD page.
Turn the beacon light on. "S" should appear next to the closed main doors.
Start an engine, once the engine is running a yellow amber text should appear next to the open doors.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

const CargoDoor: React.FC<Position & CargoDoorProps> = ({ x, y, label, width, height, engineRunning }) => {
const doorOpen = false;
const CargoDoor: React.FC<Position & CargoDoorProps> = ({ x, y, label, identifier, width, height, engineRunning }) => {
const doorOpen = identifier ? !useSimVar(`L:A32NX_${identifier}_DOOR_CARGO_LOCKED`, 'bool', 1000)[0] : false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: React hooks should not be called conditionally.

@BravoMike99 BravoMike99 requested a review from Benjozork October 16, 2024 20:09
@2hwk 2hwk added A380X Related to the A380X aircraft QA A380 Only QA only for A380 required QA Tier 1 QA Ready to Test labels Oct 19, 2024
@2hwk
Copy link
Member

2hwk commented Oct 20, 2024

Quality Assurance Report

Discord Username : 2cas
Object of testing : #9077
Aircraft : A380X
Tier of Testing : 1
Date : 20/10/2024

Testing Process:

  • Popup the DOOR SD page on the lower ecam.
  • Open a main door and a cargo door of your choice through the EFB. The associated door icon should show as amber on the DOOR SD page.
  • Manually opened doors in the main cabin deck, associated door is orange in the SD Door page
  • Turn the beacon light on. "S" should appear next to the closed main doors.
  • Start an engine, once the engine is running a yellow amber text should appear next to the open doors.

Negatives:

  • N/A

Testing Results:
Passed

@2hwk 2hwk merged commit 444d8c0 into flybywiresim:master Oct 20, 2024
7 checks passed
@BravoMike99 BravoMike99 deleted the fix-door-sd branch October 23, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft QA A380 Only QA only for A380 required QA Passed QA Ready to Test QA Tier 1
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

a380x: SD door page indications do not match door state
3 participants