Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing localization in efb #8603

Merged

Conversation

ImPlasmaTbh
Copy link
Contributor

@ImPlasmaTbh ImPlasmaTbh commented Apr 1, 2024

Fixes #7815

Summary of Changes

Updated the SimOptions page to now use loc for values for text under SimBridge connection related settings in EFB.
Updated en.json localization page to include keys that will be used as text in SimOptions setting in EFB

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub): implasma#0

Testing instructions

Turn on FlyPad
Navigate to Settings, then Sim Options page
Scroll down till you get to SimBridge settings where you can see simbridge related settings.
Text should show properly in English (you should be able to see SimBridge Host Machine, This PC, Remote PC etc. in English properly)

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

Text about using simbridge on current PC/remote PC now will use localization.
Move my changelog to the bottom of 0.12.0
@ImPlasmaTbh ImPlasmaTbh changed the title FIX: Add missing localization in efb fix: Add missing localization in efb Apr 1, 2024
@tracernz tracernz added this to the v0.12.0 milestone Apr 1, 2024
@ImPlasmaTbh ImPlasmaTbh marked this pull request as ready for review April 1, 2024 12:43
@alepouna
Copy link
Member

alepouna commented Apr 1, 2024

Make sure to notify #localization so keys are created on Localazy

@2hwk
Copy link
Member

2hwk commented Apr 2, 2024

Note: QA should probably download from artifact to ensure localazy keys are loaded.

@Popespice
Copy link

Quality Assurance Trainee Report

Discord : Popepsice
Object of testing: #8603
Tier of Testing : 1
Date : 02/04/2024

Testing Process:

  1. Log into sim
  2. Load into aircraft
  3. Activate flypad, navigate to settings
  4. Open Sim Options
  5. Observe Simbridge options appear properly in english

Negatives:
N/A

Testing Results:
Passed

Conclusions:
Works as expected

Media:
N/A

@alepouna
Copy link
Member

alepouna commented Apr 2, 2024

Note: Localization keys have been added by Mav.

@tracernz tracernz merged commit 6025e6c into flybywiresim:master Apr 3, 2024
7 checks passed
@ImPlasmaTbh ImPlasmaTbh deleted the add-missing-localization-in-efb branch April 3, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

loc: Missing localization in 'SimBridge Remote' section on the EFB
5 participants