-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing localization in efb #8603
fix: Add missing localization in efb #8603
Conversation
Text about using simbridge on current PC/remote PC now will use localization.
Move my changelog to the bottom of 0.12.0
Make sure to notify #localization so keys are created on Localazy |
Note: QA should probably download from artifact to ensure localazy keys are loaded. |
Quality Assurance Trainee Report Discord : Popepsice Testing Process:
Negatives: Testing Results: Conclusions: Media: |
Note: Localization keys have been added by Mav. |
Fixes #7815
Summary of Changes
Updated the SimOptions page to now use loc for values for text under SimBridge connection related settings in EFB.
Updated en.json localization page to include keys that will be used as text in SimOptions setting in EFB
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub): implasma#0
Testing instructions
Turn on FlyPad
Navigate to Settings, then Sim Options page
Scroll down till you get to SimBridge settings where you can see simbridge related settings.
Text should show properly in English (you should be able to see SimBridge Host Machine, This PC, Remote PC etc. in English properly)
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.