Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fms): pd format accepts sign #8582

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

tracernz
Copy link
Member

Fixes #[issue_no]

Summary of Changes

The P/D format now accepts an optional leading sign on the distance.

Note: as the feature is not yet implemented, I decided a changelog entry will only cause confusion.

Screenshots (if necessary)

References

Pylots; not books.

Additional context

Discord username (if different from GitHub):

Testing instructions

Setup a flight plan, type place/dist format (<any waypoint/fix/navaid in your plan>/<optional + or - sign, then a distance up to 999.9> e.g. OCK/-5) on the scratchpad and try to insert it into the flightplan; you should get "NOT YET IMPLEMENTED" on the scratchpad.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@tracernz tracernz added this to the v0.12.0 milestone Mar 25, 2024
@noonebling
Copy link

Quality Assurance Trainee Report

Discord : noonebling
Object of testing: 8582
Tier of Testing : 1
Date : 28/03/2024

Testing Process:

  1. Start up Sim
  2. Setup a flightplan
  3. type place/dist format (<any waypoint/fix/navaid in your plan>/<optional + or - sign, then a distance up to 999.9> e.g. OCK/-5) on the scratchpad and try to insert it into the flightplan; you should get "NOT YET IMPLEMENTED" on the scratchpad.

Negatives:
N/A

Testing Results:
Passed

Conclusions:
Works as expected

@tracernz tracernz enabled auto-merge (squash) March 28, 2024 14:22
@tracernz tracernz merged commit aab1873 into flybywiresim:master Mar 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

3 participants