Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mcdu): Disable alternate time predictions if fuel manually specified #8273

Merged
merged 5 commits into from
Nov 3, 2023

Conversation

BravoMike99
Copy link
Contributor

@BravoMike99 BravoMike99 commented Oct 27, 2023

Fixes #[issue_no]

Summary of Changes

Alternate time predictions become dashed in FUEL PRED & INIT FUEL PRED pages if fuel is specified manually.

Screenshots (if necessary)

Old & new
FUELPRED
FuelPred2

INITFUELPREDOLD
INIT FUEL PRED

References

H3/H4 FCOM
https://youtu.be/efQlfF87c8c?t=205

Additional context

Discord username (if different from GitHub):
bruno_pt99

Testing instructions

Manually specify a alternate fuel value in the INIT B & and make sure the time prediction becomes dashed then delete the value and verify that the prediction comes back.
Manually specify an alternate fuel value in the FUEL PRED Page ( only available after engines running) and verify that the time at the top of the page and next to the fuel prediction becomes dashed.
Clear the manually inserted value and make sure time becomes available on both fields

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@BravoMike99 BravoMike99 changed the title fix(mcdu): Disable alternate fuel predictions if fuel manually specified fix(mcdu): Disable alternate time predictions if fuel manually specified Oct 28, 2023
@alepouna
Copy link
Member

alepouna commented Nov 2, 2023

QA Report

Discord: alepouna
Object of testing: #8273
Tier of Testing : 1
Date : 02/11/2023

Testing Process:

  • [PASS] Manually specify a alternate fuel value in the INIT B & and make sure the time prediction becomes dashed then delete the value and verify that the prediction comes back.
  • [PASS] Manually specify an alternate fuel value in the FUEL PRED Page ( only available after engines running) and verify that the time at the top of the page and next to the fuel prediction becomes dashed.
  • [PASS] Clear the manually inserted value and make sure time becomes available on both fields

Testing Results:
Passed

@tracernz tracernz enabled auto-merge (squash) November 3, 2023 08:13
@tracernz tracernz merged commit 39b3842 into flybywiresim:master Nov 3, 2023
5 checks passed
@2hwk 2hwk added this to the v0.11.2 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

5 participants