-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fwc): Fixes the Master Warning on startup #8267
fix(fwc): Fixes the Master Warning on startup #8267
Conversation
@@ -1594,9 +1597,11 @@ export class PseudoFWC { | |||
} | |||
|
|||
if (value.failure === 3) { | |||
console.log(`Playing Master warning Source:${key}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls remove the logs and we're good to go :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duh, knew I forgot smth
|
I’d suggest keeping all the master changelogs under 0.12 and once the 0.11 release is done tidy the cherry-picked ones up all at once. |
is this even an issue on stable right now ? |
0.11 stable is master as of 2 days ago. |
QA Report Discord: saschl Testing Process: Loaded the plane and powered up the plane. No master warning audible. Testing Results: |
* Fixes the issue * removed leftover logging
Fixes #[issue_no]
Summary of Changes
On startup in C/D the aircraft plays a master warning until the startup EWD messages are empty. This was caused by the pseudo FWC checking whether the aircraft was on ground only after checking for dual engine failure which meant that the FWC didn't update the on ground status until after the check for dual engine failure and since the on ground status was initialized with false, the dual eng failure triggered on initial load.
This PR changes the order of those checks so that the setting of the on ground status happens first.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub): _chaoz_
Testing instructions
just a quick fix that shouldn't affect anything beyond the fwc initialization.
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.