Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APU): Add APU start motor failure #8260

Closed
wants to merge 14 commits into from

Conversation

uX-Pizza
Copy link

Fixes #[issue_no]

Summary of Changes

The goal of this PR is to add a failure to the APU start motor which, when active, prevents the APU from beeing started.

Screenshots (if necessary)

References

https://www.smartcockpit.com/docs/A320-Auxiliary_Power_Unit.pdf
This states the FAULT light illuminates for "no accelleration", so I dont know exactly if the FAULT light should come on or not in this case, an accuracy check would be highly appreciated.

Additional context

This is my first contribution to this project, so dont judge me too hard.

Discord username (if different from GitHub): pizza187

Testing instructions

  1. Spawn in
  2. Energize the aircraft
  3. Observe the APU starting without the failure selected / Observe the APU not starting with the failure selected
  4. Observe the N value drop back down when the failure is selected below 55% during the start cycle
  5. When the failure is deselcted the FAULT light should disappear when the APU master switch is deselected and power to the electronic control box is cut
  6. Test this in combination with the APU fire pushbutton

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@uX-Pizza uX-Pizza changed the title feat(APU) Add APU start motor failure feat(APU): Add APU start motor failure Oct 22, 2023
@uX-Pizza uX-Pizza marked this pull request as ready for review October 22, 2023 10:25
@tracernz tracernz added this to the v0.12.0 milestone Oct 24, 2023
Copy link
Member

@tracernz tracernz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry.

@tracernz
Copy link
Member

Hows does the failure actually manifest here? I think it should fail to reach the speed threshold after the first 30 seconds then the slow start fault should be triggered, causing the ECAM "APU AUTO (EMER) SHUT DOWN"?

@uX-Pizza
Copy link
Author

Hows does the failure actually manifest here? I think it should fail to reach the speed threshold after the first 30 seconds then the slow start fault should be triggered, causing the ECAM "APU AUTO (EMER) SHUT DOWN"?

I dont know exaclty. I thought the FAULT light would come on immediately as the starter motor wouldnt use any power and it is not really a slow start but just no start at all. However I didnt think about the ECAM memo, it most likely should be triggered because the APU (in the current implementation) does an auto shutdown when it had time to spool up a bit.

If you have any sources for information, please reach out to me as I think they are pretty hard to find.

@Benjozork
Copy link
Member

What is the status on this?

@Benjozork Benjozork added the Waiting For Response This issue or PR needs a response from the author label Jan 7, 2024
@uX-Pizza
Copy link
Author

uX-Pizza commented Jan 8, 2024

@Benjozork Maybe someone could look over the code as I dont really think my logic is very nice. Also there are some things missing like an ECAM message according to this. I can convert it into a draft if you want.

@2hwk 2hwk modified the milestones: v0.12.0, Backlog Feb 16, 2024
@uX-Pizza uX-Pizza closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Tier 1 Waiting For Response This issue or PR needs a response from the author
Projects
Status: ❌ Cancelled/Unfinished
Development

Successfully merging this pull request may close these issues.

4 participants