Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atsu/efb): use msfs metar rather than fsx cloud data #8256

Merged
merged 5 commits into from
Oct 20, 2023

Conversation

tracernz
Copy link
Member

@tracernz tracernz commented Oct 18, 2023

Fixes #[issue_no]

Summary of Changes

The FSX cloud data seems to have stopped updating a couple of days ago. Instead we get METARs from the sim with the API that was added a few updates back when the MSFS option is selected.

Screenshots (if necessary)

image

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Test that METARs work on the EFB home screen and in the ATSU on the MCDU with the MSFS option selected, that they are the current date, and that they match the METAR shown in the VFR MAP. Check one of the other sources e.g. VATSIM to make sure it is still okay as well.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@tracernz tracernz requested a review from svengcz October 18, 2023 09:02
Copy link
Contributor

@svengcz svengcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Saschl
Copy link
Contributor

Saschl commented Oct 19, 2023

QA Report

Tester: saschl
Date: 19.10.2023

Report:

  1. Entered multiple ICAOs in the EFB weather widget and MSFS as source and correct and up to date metar was returned
    image

  2. Performed the same inside ATSU and report matched with the data seen in the EFB.

image

Result:
Passed

@tracernz tracernz enabled auto-merge (squash) October 20, 2023 04:02
@tracernz tracernz merged commit 638b15e into flybywiresim:master Oct 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

3 participants