Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eis): move trans alt/lvl to arinc bus #8214

Merged
merged 12 commits into from
Oct 20, 2023

Conversation

BlueberryKing
Copy link
Member

@BlueberryKing BlueberryKing commented Sep 13, 2023

Fixes #[issue_no]

Summary of Changes

Utilize the FMGC DMC bus to transmit transition altitude and transition level. This should not have any visible effect. However, it gets rid of the undocumented L:AIRLINER_TRANS_ALT and L:AIRLINER_APPR_TRANS_ALT variables.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  • Check that the QNH/STD indication on the PFD still blinks once the aircraft crosses the transition altitude/level in the climb/descent.
  • Check that there is no blinking when the corresponding fields are empty in the MCDU.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@BlueberryKing BlueberryKing marked this pull request as ready for review September 13, 2023 19:33
@Sioux812
Copy link

Just to further clarify this topic further, Thales logic for the APPR Perf page will auto populate whatever the typical Transition FL is for that country/region plus 500ft. This is to prevent the PFD altimeter settings flashing if pilots were instructed to level off at the Transition Level during descent (pilots should be on the provided altimeter anytime at and below the transition level). So, for example we would see on the APPR performance page "TRANS FL" and below FL45 (or FL65, FL185, etc.).
APPR PERF Page
IMG_0393

@BlueberryKing
Copy link
Member Author

Just to further clarify this topic further, Thales logic for the APPR Perf page will auto populate whatever the typical Transition FL is for that country/region plus 500ft. This is to prevent the PFD altimeter settings flashing if pilots were instructed to level off at the Transition Level during descent (pilots should be on the provided altimeter anytime at and below the transition level). So, for example we would see on the APPR performance page "TRANS FL" and below FL45 (or FL65, FL185, etc.). APPR PERF Page IMG_0393

Thanks for the info! Yes, on Honeywell, the transition altitude and transition level should be imported from the navigation database as well. Unfortunately, we don't have access to this through MSFS. So in the A32NX, it's imported from the flight plan if one is uplinked from SimBrief.

@Sioux812
Copy link

Is it possible to make the FBW version auto add the 500ft to the transition level if it successfully uplinks one then?

@BlueberryKing
Copy link
Member Author

Is it possible to make the FBW version auto add the 500ft to the transition level if it successfully uplinks one then?

To my knowledge, Honeywell inserts the transition altitude/level directly from the database without adding anything. So we will stick with this behavior for now.

Honeywell
image
vs Thales:
image

@BlueberryKing BlueberryKing requested a review from 2hwk September 18, 2023 09:03
@Saschl
Copy link
Contributor

Saschl commented Oct 20, 2023

QA Report

Tester: saschl
Date: 20.10.2023

Report:

  1. Check that the QNH/STD indication on the PFD still blinks once the aircraft crosses the transition altitude/level in the climb/descent.
    PASS

  2. Check that there is no blinking when the corresponding fields are empty in the MCDU.
    PASS

Summary:
Passed

@tracernz tracernz merged commit 7393f1d into flybywiresim:master Oct 20, 2023
5 checks passed
flogross89 added a commit to flogross89/aircraft that referenced this pull request Feb 3, 2024
- match slats+flaps position dots to actual positions
- remove speed tape outline right
- remove spaces in FMA E2 cell (i.e. 1FD2 instead of 1 FD 2)
- fix LS info box position (push a little bit upwards)
- integrate PR flybywiresim#8235 (FMA pos. update) & flybywiresim#8214 (move trans alt/lvl to arinc bus)
- make tens of digital altitude readout font smaller & push to right
- altitude tape now listens to baro corrected altitude
flogross89 added a commit to flogross89/aircraft that referenced this pull request Feb 3, 2024
- match slats+flaps position dots to actual positions
- remove speed tape outline right
- remove spaces in FMA E2 cell (i.e. 1FD2 instead of 1 FD 2)
- fix LS info box position (push a little bit upwards)
- integrate PR flybywiresim#8235 (FMA pos. update) & flybywiresim#8214 (move trans alt/lvl to arinc bus)
- make tens of digital altitude readout font smaller & push to right
- altitude tape now listens to baro corrected altitude
flogross89 added a commit that referenced this pull request Feb 7, 2024
* - import Arinc429Word from fbw-sdk (remove copy from @shared)
- match slats+flaps position dots to actual positions
- remove speed tape outline right
- remove spaces in FMA E2 cell (i.e. 1FD2 instead of 1 FD 2)
- fix LS info box position (push a little bit upwards)
- integrate PR #8235 (FMA pos. update) & #8214 (move trans alt/lvl to arinc bus)
- make tens of digital altitude readout font smaller & push to right
- altitude tape now listens to baro corrected altitude

* revert changes to flaps/slats position

* revert font for tens of altitude

* activate GearIndicator, use LGCIU input for now

* PFD linting

* QNH, RA and altitude readout position update
@2hwk 2hwk added this to the v0.11.2 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

5 participants