Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mcdu): improve PERF pages #8205

Merged

Conversation

BlueberryKing
Copy link
Member

@BlueberryKing BlueberryKing commented Sep 8, 2023

Fixes #8190

Summary of Changes

  • Various layout improvements of the PERF CLB, PERF CRZ and PERF DES pages.
  • Implement option to preselect a managed descent speed.
  • Implement CHECK SPEED MODE message.
  • Only allow preselecting a selected CLB speed in CAS.
  • Allow preselecting a cruise speed as CAS or Mach.
  • Show cruise speed as CAS below FL250 and as Mach above FL250.
  • Implement option to modify PRED TO altitude on PERF CLB and PERF DES pages.
  • Add DES predictions in selected modes.

Screenshots (if necessary)

image
image
image

References

Additional context

Limitations:

  • No EXPEDITE predictions yet on the PERF DES page.

Discord username (if different from GitHub): BlueberryKing

Testing instructions

  • CHECK SPEED MODE
    • This message should appear when you the Climb or Cruise phase starts with a selected speed on the FCU, but no preselected speed on the respective CLB or CRZ page.
  • CLB speed preselection
    • Check that you can preselect a speed between 100 kts and 350 kts. Check that you cannot preselect a Mach number.
    • Check that you can clear the preselected speed with the CLR key. Check that you can also clear it by clicking the LSK next to the managed speed target
    • Check that the preselected speed activates when the aircraft enters the CLB phase and that you do not see a CHECK SPEED MODE message
  • CRZ speed preselection
    • Check that you can preselect a speed between 100 kts and 350 kts or a Mach number.
    • Check that you can clear the preselected speed with the CLR key. Check that you can also clear it by clicking the LSK next to the managed speed target
    • Check that the preselected speed activates when the aircraft enters the CRZ phase and that you do not see a CHECK SPEED MODE message
  • DES speed preselection
    • Check that you can enter a Mach number as "MM/" or a CAS as "/CAS" on the DES page. This should be the managed target speed when the DES phase activates
    • Check that you can enter a CAS as "CAS", the Mach number should automatically be filled in as 0.80.
    • Check that you can clear this field to return to the precomputed Mach/CAS based on the cost index.
  • CLB and DES predictions on the PERF page
    • In the CLB or DES phases respectively, check that you can modify the altitudes in the PRED TO field. On the CLB phase, any altitude between the aircraft's current altitude and the cruise altitude should be allowed. On the DES page, any altitude below the aircraft's current altitude should be allowed. Using CLR on the PRED TO field should return to the FCU altitude.
  • Speed shown on the CRZ page
    • The speed shown on the CRZ page should be a Mach number if the cruise level is above FL250, a CAS otherwise.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@alepouna
Copy link
Member

QA Report

Discord: alepouna
Object of testing: #8205
Tier of Testing : 1
Date : 26/10/2023

Testing Process:

  • CHECK SPEED MODE
    • [PASS] This message should appear when you the Climb or Cruise phase starts with a selected speed on the FCU, but no preselected speed on the respective CLB or CRZ page.
  • CLB speed preselection
    • [PASS] Check that you can preselect a speed between 100 kts and 350 kts. Check that you cannot preselect a Mach number.
    • [PASS] Check that you can clear the preselected speed with the CLR key. Check that you can also clear it by clicking the LSK next to the managed speed target
    • [PASS] Check that the preselected speed activates when the aircraft enters the CLB phase and that you do not see a CHECK SPEED MODE message
  • CRZ speed preselection
    • [PASS] Check that you can preselect a speed between 100 kts and 350 kts or a Mach number.
    • [PASS] Check that you can clear the preselected speed with the CLR key. Check that you can also clear it by clicking the LSK next to the managed speed target
    • [PASS] Check that the preselected speed activates when the aircraft enters the CRZ phase and that you do not see a CHECK SPEED MODE message
  • DES speed preselection
    • [PASS] Check that you can enter a Mach number as "MM/" or a CAS as "/CAS" on the DES page. This should be the managed target speed when the DES phase activates
    • [PASS] Check that you can enter a CAS as "CAS", the Mach number should automatically be filled in as 0.80.
    • [PASS] Check that you can clear this field to return to the precomputed Mach/CAS based on the cost index.
  • CLB and DES predictions on the PERF page
    • [PASS] In the CLB or DES phases respectively, check that you can modify the altitudes in the PRED TO field. On the CLB phase, any altitude between the aircraft's current altitude and the cruise altitude should be allowed. On the DES page, any altitude below the aircraft's current altitude should be allowed. Using CLR on the PRED TO field should return to the FCU altitude.
  • Speed shown on the CRZ page
    • [PASS] The speed shown on the CRZ page should be a Mach number if the cruise level is above FL250, a CAS otherwise.

Testing Results:
Passed

@BlueberryKing BlueberryKing force-pushed the perf-page-improvements branch from 929b1a0 to 1924e76 Compare October 25, 2023 22:29
@BlueberryKing BlueberryKing enabled auto-merge (squash) October 25, 2023 22:32
@BlueberryKing BlueberryKing merged commit 0afca04 into flybywiresim:master Oct 25, 2023
5 checks passed
Saschl pushed a commit that referenced this pull request Oct 26, 2023
* Implement CHECK SPEED MODE message

* Improve layout on PERF pages

* Allow modification of PRED TO altitudes

* Fix displayed managed speed

* Take speed constraint into account for clb speed

* Update changelog

* Fix slash formatting

* Use Mach 0.80 for DES CAS selection only

* Fix input parsing

* Fix layout before FROM/TO entry

* Inhibit CHECK SPEED MODE in excessive attitude

* Fix slash formatting again

* Allow Mach only entries

* Make * on CRZ page small

* fix: changelog 0.12

---------

Co-authored-by: Michael Corcoran <[email protected]>
@2hwk 2hwk modified the milestones: v0.12.0, v0.11.2 Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

Perf Cruise page speed is incorrectly displayed
4 participants