Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed sound, cones and chocks which depend on LIGHT BEACON (ON)) var #7689

Merged

Conversation

frankkopp
Copy link
Member

@frankkopp frankkopp commented Jan 5, 2023

Summary of Changes

Wheelchocks and Safety Cones depended on LIGHT BEACON ON
Cabin announcements (Sounds) depended on LIGHT BEACON

LIGHT BEACON == Switch Position
LIGHT BEACON ON == Actual Beacon Light State

This PR fixes this so that:

  • Chocks and Cones are gone when the switch is on
    • this avoids the case of an unpowered aircraft on the runway or taxiway having them visible
  • Cabin announcements only play when beacon lights are actually on

Discord username (if different from GitHub): Cdr_Maverick#6475

Testing instructions

  • Test chocks & cones visibility in powered an unpowered states depending on switch
  • Test announcements playing only when aircraft is powered and switch is on.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@frankkopp frankkopp marked this pull request as ready for review January 5, 2023 16:25
Copy link
Member

@hotshotp hotshotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sound change, LGTM

@frankkopp frankkopp self-assigned this Jan 6, 2023
@Letreivchen
Copy link

Quality Assurance Tester/Trainee Report

Discord : Letreiv#9404
Object of testing: #7689
Tier of Testing : 1
Date : 06.01.2023

Testing Process:
Test chocks & cones visibility in powered an unpowered states depending on switch- OK
Test announcements playing only when aircraft is powered and switch is on. -OK
Checked that announcements don't play again after power loss followed by power regain in flight- OK

Negatives:
none

Testing Results:
Passed

Conclusions:
LGTM

Media:

igor8518 pushed a commit to igor8518/a32nx that referenced this pull request Jan 6, 2023
@frankkopp frankkopp force-pushed the fix-beacon-lt-dependencies branch from 3cf4cf9 to 23da0d5 Compare January 7, 2023 17:27
@frankkopp frankkopp added the Exp Available on experimental branch (for testing) label Jan 7, 2023
@dragold
Copy link

dragold commented Jan 9, 2023

QA Tester Report

Name: Mr.Blank#6197
Date of testing MM/DD/YYYY:01/09/2023
PR Tested: 7689
Tier of testing:1

Testing technique: tryouts
Test Instructions:
Test chocks & cones visibility in powered and unpowered states depending on the switch
Test announcements play only when the aircraft is powered and the switch is on.

Methodology
All as per insturction
Negatives: NIL
Testing Results: PASS
Conclusions: results were of normal outputs

@frankkopp frankkopp merged commit 5140532 into flybywiresim:master Jan 9, 2023
@frankkopp frankkopp deleted the fix-beacon-lt-dependencies branch January 9, 2023 14:27
@2hwk 2hwk added this to the v0.10.0 milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exp Available on experimental branch (for testing) Needs Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants