Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hyd): improve lgciu state machine #7685

Merged
merged 11 commits into from
Jan 13, 2023

Conversation

crocket63
Copy link
Contributor

@crocket63 crocket63 commented Jan 2, 2023

Fixes #[issue_no]

Summary of Changes

Avoids unwanted gear movement when proximity sensors fail

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

When gear is secured up, any gear failure won't make gear system move.
When gear is secured down, any gear failure won't make gear system move.

Gravity extension activation and reversion works without gear impacting doors (door closing before gear)

Gear failures impact the gear as expected

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@crocket63 crocket63 marked this pull request as ready for review January 2, 2023 17:42
Copy link
Contributor

@Gurgel100 Gurgel100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mico975
Copy link
Contributor

mico975 commented Jan 11, 2023

Quality Assurance Tester Report

Discord : mico#3145
Object of testing: #7685
Tier of Testing : 1
Date : 11/01/2023

Testing Process:
When gear is secured up, any gear failure won't make gear system move. - OK
When gear is secured down, any gear failure won't make gear system move. - OK

Gravity extension activation and reversion works without gear impacting doors (door closing before gear) - OK

Gear failures impact the gear as expected - OK

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM

@Saschl Saschl enabled auto-merge (squash) January 13, 2023 22:55
@Saschl Saschl merged commit dc248a4 into flybywiresim:master Jan 13, 2023
@2hwk 2hwk added this to the v0.10.0 milestone Jan 29, 2023
@crocket63 crocket63 deleted the fix_lgciu_statemachine branch February 14, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants