Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flexible engines mounting #7676

Merged
merged 15 commits into from
Jan 13, 2023

Conversation

crocket63
Copy link
Contributor

@crocket63 crocket63 commented Dec 30, 2022

Fixes #[issue_no]

Summary of Changes

This PR adds a physical model for engine mounts, so that engines will wobble when plane is experiencing sudden accelerations.

Screenshots (if necessary)

References

https://youtu.be/O-qnWaqDwxg?t=257

Additional context

Discord username (if different from GitHub):

Testing instructions

No tests expected for now, this will be tested ingame on A380 plane

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@crocket63 crocket63 marked this pull request as ready for review January 6, 2023 12:26
Copy link
Contributor

@Gurgel100 Gurgel100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I don't quite understand what is happening it looks good ;)

src/systems/systems/src/engine/engine_wing_flex.rs Outdated Show resolved Hide resolved
src/systems/systems/src/engine/engine_wing_flex.rs Outdated Show resolved Hide resolved
@Gurgel100
Copy link
Contributor

Just out of interest, are you considering to consider engine vibration later as well?

Copy link
Contributor

@Gurgel100 Gurgel100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crocket63
Copy link
Contributor Author

Just out of interest, are you considering to consider engine vibration later as well?

Not sure it would be relevant, would probably be higher frequencies with less amplitude, so more energy but not visible as the structural wobble. I can be wrong though :p

@Gurgel100
Copy link
Contributor

Not sure it would be relevant, would probably be higher frequencies with less amplitude, so more energy but not visible as the structural wobble. I can be wrong though :p

Well at least in case of a fatal engine failure the vibration certainly make the engine wobble :D

@crocket63
Copy link
Contributor Author

Oh yeah when it explodes yes lol. I bet we'll have to figure out something function of speed then to excite the animation :)

@crocket63 crocket63 enabled auto-merge (squash) January 13, 2023 08:53
@crocket63 crocket63 merged commit 233ba9b into flybywiresim:master Jan 13, 2023
@2hwk 2hwk added this to the v0.10.0 milestone Jan 29, 2023
@crocket63 crocket63 deleted the test_engine_flex branch February 14, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants