Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(efb): landing calculator widget runway shows correct runway heading #7674

Merged
merged 2 commits into from
Jan 7, 2023

Conversation

2hwk
Copy link
Member

@2hwk 2hwk commented Dec 30, 2022

Fixes #[issue_no]

Summary of Changes

Currently landing runway widget shows 18/00 when heading is between 1-5 degrees. Runway number should instead be 18/36.

Screenshots (if necessary)

image

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  • Open landing calculator page on EFB. Page should first appear with no runway heading (Runway labels ??/??)
  • Enter runway heading 0-4. Runway numbers should be 18/36
  • Enter runway heading 5-10. Runway numbers should be 19/01
  • Enter runway heading 175-184. Runway numbers should be 36/18
  • Enter runway heading 355-360. Runway numbers should be 18/36

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@2hwk 2hwk requested a review from ErickSharp December 30, 2022 08:42
@2hwk 2hwk added this to the v0.10.0 milestone Dec 30, 2022
@Letreivchen
Copy link

Quality Assurance Tester/Trainee Report

Discord : Letreiv#9404
Object of testing: #7674
Tier of Testing : 1
Date : 06.01.2022

Testing Process:
Checked the following points:
Open landing calculator page on EFB. Page should first appear with no runway heading (Runway labels ??/??)- OK
Enter runway heading 0-4. Runway numbers should be 18/36 -OK
Enter runway heading 5-10. Runway numbers should be 19/01 -OK
Enter runway heading 175-184. Runway numbers should be 36/18 -OK
Enter runway heading 355-360. Runway numbers should be 18/36
Did some spot checks
(Runway labels ??/??) appear again when pressing the clear button

Negatives:
none

Testing Results:
Passed

Conclusions:
Just something i noticed, the field is not limited to 360° but it will just use the heading -360° of when the entered value is >360

Media:

@2hwk 2hwk force-pushed the flypad-fix-runway branch from 08a835c to a771fdb Compare January 7, 2023 15:48
@2hwk 2hwk enabled auto-merge (squash) January 7, 2023 15:52
@2hwk 2hwk merged commit 81a8ee3 into flybywiresim:master Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants