Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(atsu): Coupled atsu and DATALINK STATUS page #7656

Merged

Conversation

StenAfMARS
Copy link
Contributor

@StenAfMARS StenAfMARS commented Dec 18, 2022

Fixes #[issue_no]

Summary of Changes

Coupled the DATALINK STATUS page onto the atsu, per request of @svengcz.
Added new functions to atsu to let the DATALINK STATUS page retrieve data directly from the atsu.

Functions added:
DatalinkStatus and DatalinkMode, for both VHF3, HF and SATCOM.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub): space_viking#0186

Testing instructions

There really isn't too much to test in this as there visually shouldn't be any difference. 2nd line of VHF should read ATC/AOC if hoppie is enabled and AOC ONLY if disabled. SATCOM should read "NOT INSTALLED" if satcom is disabled in the EFB and "DLK NOT AVAIL" if satcom is enabled.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artefact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@StenAfMARS StenAfMARS changed the title feat(atsu): coupled atsu to DATALINK STATUS page feat(atsu): Coupled atsu and DATALINK STATUS page Dec 18, 2022
src/atsu/src/DatalinkStatusCodes.ts Show resolved Hide resolved
src/atsu/src/ATSU.ts Outdated Show resolved Hide resolved
@StenAfMARS StenAfMARS marked this pull request as draft December 19, 2022 12:28
@StenAfMARS StenAfMARS marked this pull request as ready for review December 19, 2022 19:42
@StenAfMARS StenAfMARS requested a review from svengcz December 27, 2022 22:41
@mico975
Copy link
Contributor

mico975 commented Jan 11, 2023

Quality Assurance Tester Report

Discord : mico#3145
Object of testing: #7656
Tier of Testing : 1
Date : 11/01/2023

Testing Process:
There really isn't too much to test in this as there visually shouldn't be any difference.
2nd line of VHF should read ATC/AOC if hoppie is enabled and AOC ONLY if disabled. - OK
SATCOM should read "NOT INSTALLED" if satcom is disabled in the EFB - OK
and "DLK NOT AVAIL" if satcom is enabled. - OK

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM

@Saschl Saschl enabled auto-merge (squash) January 11, 2023 21:36
@Saschl Saschl merged commit bafb78c into flybywiresim:master Jan 11, 2023
@2hwk 2hwk added this to the v0.10.0 milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants