Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add aircraft version check and user message when using old version #7655

Merged
merged 53 commits into from
Jan 14, 2023

Conversation

frankkopp
Copy link
Member

@frankkopp frankkopp commented Dec 18, 2022

Summary of Changes

This PR introduces a check of the version of the currently running aircraft against the latest github versions.

This PR adds a comprehensive version tag to the a32nx_build_info.json which is then used in the EFB code to check against the github version. A MSFS notification will be shown and the flyPad will also show the old version state in the status bar.

Notification policy:

  • when the version is older than the latest Stable release
  • when version is equal or newer and branch is dev or exp then compare commit hash
    • if different and build date of aircraft is older than build date of latest dev/exp commit by 3 days

Screenshots (if necessary)

image
image
image

2022-12-26_13h48_02.mp4

Discord username (if different from GitHub): Cdr_Maverick#6475

Testing instructions

To test this the a32nx_build-info.json file needs to be edited to "pretend" to be on an outdated version.

All editions;

  • To check for outdated main version change the version info to an older version (e.g. 0.9.0)

Dev and Exp

  • Change the version tag to something like v0.10.0-dev.124567 or v0.10.0-exp.124567
  • As long as the commit sha is different to the last commit in dev or exp it will check for build time.
    • If older than 3 days the message should appear - change the built date to test this
  • If commit sha is identical no message should appear. (change the commit sha in the version string)

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@frankkopp frankkopp marked this pull request as ready for review December 18, 2022 00:50
@frankkopp frankkopp marked this pull request as draft December 18, 2022 01:17
@frankkopp frankkopp force-pushed the version-selfcheck branch 2 times, most recently from 7eba8c8 to 607cc9f Compare December 20, 2022 11:09
@frankkopp frankkopp changed the title feat: Add a version check and user message when using old version feat: Add aircraft version check and user message when using old version Dec 20, 2022
@frankkopp frankkopp marked this pull request as ready for review December 20, 2022 11:13
@frankkopp frankkopp self-assigned this Dec 20, 2022
package.json Outdated Show resolved Hide resolved
frankkopp added a commit that referenced this pull request Dec 26, 2022
@frankkopp frankkopp added the Exp Available on experimental branch (for testing) label Dec 26, 2022
frankkopp added a commit that referenced this pull request Dec 26, 2022
@2hwk 2hwk added this to the v0.10.0 milestone Dec 28, 2022
@frankkopp frankkopp force-pushed the version-selfcheck branch 2 times, most recently from b26ebc1 to 0d50a5f Compare December 29, 2022 13:57
@mico975
Copy link
Contributor

mico975 commented Jan 1, 2023

Quality Assurance Tester Report

Discord : mico#3145
Object of testing: #7655
Tier of Testing : 1
Date : 01/01/2023

Testing Process:
To check for outdated main version change the version info to an older version (e.g. 0.9.0) - OK

Change the version tag to something like v0.10.0-dev.124567 or v0.10.0-exp.124567
As long as the commit sha is different to the last commit in dev or exp it will check for build time.
If older than 3 days the message should appear - change the built date to test this - OK
If commit sha is identical no message should appear. (change the commit sha in the version string) - OK

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM

Media:
image

@frankkopp frankkopp merged commit dc81f48 into flybywiresim:master Jan 14, 2023
@frankkopp frankkopp deleted the version-selfcheck branch January 14, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exp Available on experimental branch (for testing) QA Tier 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants