Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pushback did not pause when leaving flyPad Pushback page #7645

Merged
merged 6 commits into from
Dec 25, 2022

Conversation

frankkopp
Copy link
Member

@frankkopp frankkopp commented Dec 9, 2022

Summary of Changes

When leaving the flyPad Pushback page while actually pushing back should set the pushback movement to pause.
This didn't work and this PR fixes this.

Also minor refactor to allow for better usage via LVARs in external tools.

Discord username (if different from GitHub): Cdr_Maverick#6475

Testing instructions

Test Pushback in general.
Test leaving the Pushback page while moving. Aircraft should stop.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@frankkopp frankkopp self-assigned this Dec 9, 2022
@frankkopp frankkopp marked this pull request as ready for review December 9, 2022 21:38
@frankkopp frankkopp force-pushed the pushback-fix branch 2 times, most recently from acf6745 to c907a5b Compare December 11, 2022 23:46
@2hwk 2hwk added this to the v0.10.0 milestone Dec 12, 2022
@frankkopp frankkopp force-pushed the pushback-fix branch 3 times, most recently from 2a7baf3 to e8632b0 Compare December 19, 2022 19:33
Copy link
Contributor

@Saschl Saschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankkopp frankkopp added the Exp Available on experimental branch (for testing) label Dec 20, 2022
Saschl added a commit that referenced this pull request Dec 22, 2022
beheh pushed a commit that referenced this pull request Dec 22, 2022
@marcman86
Copy link
Contributor

Quality Assurance Report

Discord: marcman86#4907
Object of testing: #7645
Tier of Testing: 1
Date: 22/12/2022

Testing Process:

  • Spawned at gate at EDDP
  • Started up plane for taxi
  • Turned on EFB
  • Started pushback and checked all movements
  • Left pushback page > movement stoped
  • Go back to pushback page and resumed pushback
  • Turned off EFB > movement stoped
  • Turned on EFB again and resumed pushback
  • Tested the same for controller inputs

Negatives: -

Testing Results: Passed
Conclusions: Works for me

Hope this helps :-)

@mico975
Copy link
Contributor

mico975 commented Dec 25, 2022

Quality Assurance Tester Report

Discord : mico#3145
Object of testing: #7645
Tier of Testing : 1
Date : 25/12/2022

Testing Process:
Test Pushback in general. - OK
Test leaving the Pushback page while moving. Aircraft should stop. - OK

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM, maybe we can add a toggle for this feature in the future, because I somehow like to check other stuff on the EFB while pushing back with default to on.

@frankkopp frankkopp merged commit 9553acd into flybywiresim:master Dec 25, 2022
@frankkopp frankkopp deleted the pushback-fix branch December 25, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exp Available on experimental branch (for testing) QA Tier 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants