Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fmgc): transition names and final approach slope #7637

Merged
merged 4 commits into from
Dec 7, 2022

Conversation

tracernz
Copy link
Member

@tracernz tracernz commented Dec 6, 2022

Fixes #[issue_no]

Summary of Changes

There is some new navdata available with AAU1. This PR makes use of it while still being compatible with previous versions of the sim. Transition names have actually been there for a long time (the begining?) but were just filled with the waypoint names... now they have the proper names... I still keep the old way as well just for bad navdata e.g. YWKS in here has blank approach transition names. There are flight plan system issues requiring much larger changes stopping the slope appearing on the final/destination leg of the approach.

Screenshots (if necessary)

NZAA RNP23LY
image
ZQN:
image
Polderbaan ILS:
image

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Load some approaches and check transition names (if they're different to the waypoint names in them) with AAU1 beta. Ideally check with stable MSFS as well, where this patch won't change anything.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@tracernz tracernz added this to the v0.10.0 milestone Dec 6, 2022
@mico975
Copy link
Contributor

mico975 commented Dec 6, 2022

Quality Assurance Tester Report

Discord : mico#3145
Object of testing: #7637
Tier of Testing : 1
Date : 06/12/2022

Testing Process:
Load some approaches and check transition names (if they're different to the waypoint names in them) with AAU1 beta. - OK
Ideally check with stable MSFS as well, where this patch won't change anything. - Not reverting, sorry 🤣

Also checked SID transitions and it also works. 🚀

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM, even SID transitions work as intended.

Media:
LFPG APP
image
LJMB APP
image
LIMC DEP
image
LJLJ APP
image

@tracernz
Copy link
Member Author

tracernz commented Dec 7, 2022

Tested on the current retail build myself.

@tracernz tracernz merged commit 5697964 into flybywiresim:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants