feat(hyd): faster core hydraulics solver #7635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gurgel100
requested changes
Dec 21, 2022
…eat_faster_core_hydraulics
Saschl
added a commit
that referenced
this pull request
Dec 22, 2022
beheh
pushed a commit
that referenced
this pull request
Dec 22, 2022
Eearslya
pushed a commit
to Eearslya/a32nx
that referenced
this pull request
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
As wasm performances proves to be really good, this PR sets all the hydraulic calculations to 100hz, which should help in some fast flow transients use cases, such as gear or multiple flight control inputs.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
Check no noticeable performance degradation.
Please check as many hydraulic cases as possible and search for any regression, including brakes/steering/cargo doors/hydraulic leaks...
On gear movements pressure down spikes should not go as low as before but should still trigger PTU.
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.