Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: polar heading/track part 1 #7633

Merged
merged 16 commits into from
Jan 11, 2023
Merged

feat: polar heading/track part 1 #7633

merged 16 commits into from
Jan 11, 2023

Conversation

tracernz
Copy link
Member

@tracernz tracernz commented Dec 3, 2022 •
edited
Loading

Fixes #[issue_no]

Summary of Changes

This pull request is the first step to full polar nav capability for the A32NX (and by extension A380X). The ADIRU part is implemented, along with the PFD and ND parts. FCU, FMGC/MCDU, FWC/ECAM, and other systems are not touched in this PR.

Known issues:

  • MCDU does not display true heading data, nor stop show "magnetic" data
  • AP/FCU in heading mode is unaware of true headings/tracks
  • Many other things in the systems that aren't touched yet

Screenshots (if necessary)

(Graphical tweaks since this)
image

Flashing at slat extension on PFD, different TRUE flag with approach message on ND:
https://user-images.githubusercontent.com/9995998/206412158-93802570-650e-4e18-9b37-2d31d24c93e0.mp4

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Fly into, out of and around polar areas (> 82 north or south and in the magnetic north region). The Lvar L:A32NX_PUSH_TRUE_REF can be used to simulate the TRUE REF pushbutton that isn't actually present in the Asobo A320 flight deck (this will allow you to enter TRUE REF mode outside of polar regions).

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@tracernz tracernz added this to the v0.10.0 milestone Dec 3, 2022
@tracernz tracernz force-pushed the mrc-big-planes-might-go-polar branch from 8dc75f1 to 892e569 Compare December 5, 2022 09:51
@tracernz tracernz changed the title feat(adiru): polar heading/track feat: polar heading/track Dec 5, 2022
@tracernz tracernz force-pushed the mrc-big-planes-might-go-polar branch from 31567c1 to 1d14c8b Compare December 7, 2022 09:00
@tracernz tracernz force-pushed the mrc-big-planes-might-go-polar branch from 7baf94c to 75fe2ab Compare December 8, 2022 08:47
@tracernz tracernz marked this pull request as ready for review December 8, 2022 09:10
@tracernz tracernz changed the title feat: polar heading/track feat: polar heading/track part 1 Dec 8, 2022
@tracernz tracernz marked this pull request as draft December 8, 2022 09:39
@tracernz
Copy link
Member Author

tracernz commented Dec 8, 2022

Ugh, forgot about rust tests.

@tracernz tracernz marked this pull request as ready for review December 9, 2022 06:53
@tracernz tracernz force-pushed the mrc-big-planes-might-go-polar branch from 134b16e to 9c82ae7 Compare December 9, 2022 07:58
@tracernz tracernz force-pushed the mrc-big-planes-might-go-polar branch from 9c82ae7 to e745f46 Compare December 21, 2022 09:16
davidwalschots
davidwalschots reviewed Dec 22, 2022
View reviewed changes
Copy link
Member

@davidwalschots davidwalschots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the Rust portion of code. All good, one suggestion and one nitpick thingie. 😀

src/systems/systems/src/navigation/adirs.rs Outdated Show resolved Hide resolved
src/systems/systems/src/navigation/adirs.rs Outdated Show resolved Hide resolved
@tracernz @davidwalschots
fix: review feedback
1e22a04 
Co-authored-by: David Walschots <[email protected]>
Benjozork
Benjozork reviewed Dec 30, 2022
View reviewed changes
docs/a320-simvars.md Outdated Show resolved Hide resolved
docs/a320-simvars.md Outdated Show resolved Hide resolved
src/fmgc/src/guidance/lnav/LnavDriver.ts Show resolved Hide resolved
@tracernz tracernz requested a review from Benjozork January 2, 2023 13:47
tracernz added a commit that referenced this pull request Jan 4, 2023
@tracernz
feat: polar heading/track part 1 #7633 @2d51cdf
d261a68 
commit 2d51cdf
Author: Michael Corcoran <[email protected]>
Date:   Tue Jan 3 02:45:23 2023 +1300

    doc: simvars

commit 1e22a04
Author: Michael Corcoran <[email protected]>
Date:   Thu Dec 22 23:02:48 2022 +1300

    fix: review feedback

    Co-authored-by: David Walschots <[email protected]>

commit 22212d6
Author: Michael Corcoran <[email protected]>
Date:   Wed Dec 21 23:17:17 2022 +1300

    fix(fcu): awful hack for AP in hdg/trk when changing true ref

commit e745f46
Author: Michael Corcoran <[email protected]>
Date:   Wed Dec 21 22:03:15 2022 +1300

    fix(ND): adjust true indications based on new refs

commit ab90e3c
Author: Michael Corcoran <[email protected]>
Date:   Fri Dec 9 19:52:09 2022 +1300

    fix(adiru): add new tests and fix old tests

commit e5a3565
Author: Michael Corcoran <[email protected]>
Date:   Thu Dec 8 22:03:39 2022 +1300

    fix(nd): adjust to 320 ref

commit 2d7d386
Author: Michael Corcoran <[email protected]>
Date:   Thu Dec 8 21:45:12 2022 +1300

    doc: changelog and pb simvar

commit f104d5a
Author: Michael Corcoran <[email protected]>
Date:   Wed Dec 7 22:43:47 2022 +1300

    fix(nd): svg vis attr always gets me

commit 4e39c35
Author: Michael Corcoran <[email protected]>
Date:   Wed Dec 7 21:52:39 2022 +1300

    feat(nd): true ref for navaids

commit 9756890
Author: Michael Corcoran <[email protected]>
Date:   Tue Dec 6 22:37:24 2022 +1300

    fix(pfd): true flag flashes at slat extension

commit 7db3ba6
Author: Michael Corcoran <[email protected]>
Date:   Mon Dec 5 23:02:02 2022 +1300

    fix(nd): rect vis

commit 3a1caad
Author: Michael Corcoran <[email protected]>
Date:   Mon Dec 5 22:46:57 2022 +1300

    feat(pfd): true ref

    Still QFU dagger to be done (I think)

commit c67cbf5
Author: Michael Corcoran <[email protected]>
Date:   Mon Dec 5 22:44:29 2022 +1300

    feat(nd): true ref

    Still work to be done around radio nav indications.

commit dc707ef
Author: Michael Corcoran <[email protected]>
Date:   Mon Dec 5 22:41:23 2022 +1300

    feat(font): diamond for eis font

commit 7db9163
Author: Michael Corcoran <[email protected]>
Date:   Sun Dec 4 02:23:15 2022 +1300

    feat(adiru): polar heading/track
@tracernz tracernz added Exp Available on experimental branch (for testing) and removed Needs Code Review labels Jan 4, 2023
igor8518 pushed a commit to igor8518/a32nx that referenced this pull request Jan 6, 2023
@tracernz @igor8518
feat: polar heading/track part 1 flybywiresim#7633 @2d51cdf
ef92a96 
commit 2d51cdf
Author: Michael Corcoran <[email protected]>
Date:   Tue Jan 3 02:45:23 2023 +1300

    doc: simvars

commit 1e22a04
Author: Michael Corcoran <[email protected]>
Date:   Thu Dec 22 23:02:48 2022 +1300

    fix: review feedback

    Co-authored-by: David Walschots <[email protected]>

commit 22212d6
Author: Michael Corcoran <[email protected]>
Date:   Wed Dec 21 23:17:17 2022 +1300

    fix(fcu): awful hack for AP in hdg/trk when changing true ref

commit e745f46
Author: Michael Corcoran <[email protected]>
Date:   Wed Dec 21 22:03:15 2022 +1300

    fix(ND): adjust true indications based on new refs

commit ab90e3c
Author: Michael Corcoran <[email protected]>
Date:   Fri Dec 9 19:52:09 2022 +1300

    fix(adiru): add new tests and fix old tests

commit e5a3565
Author: Michael Corcoran <[email protected]>
Date:   Thu Dec 8 22:03:39 2022 +1300

    fix(nd): adjust to 320 ref

commit 2d7d386
Author: Michael Corcoran <[email protected]>
Date:   Thu Dec 8 21:45:12 2022 +1300

    doc: changelog and pb simvar

commit f104d5a
Author: Michael Corcoran <[email protected]>
Date:   Wed Dec 7 22:43:47 2022 +1300

    fix(nd): svg vis attr always gets me

commit 4e39c35
Author: Michael Corcoran <[email protected]>
Date:   Wed Dec 7 21:52:39 2022 +1300

    feat(nd): true ref for navaids

commit 9756890
Author: Michael Corcoran <[email protected]>
Date:   Tue Dec 6 22:37:24 2022 +1300

    fix(pfd): true flag flashes at slat extension

commit 7db3ba6
Author: Michael Corcoran <[email protected]>
Date:   Mon Dec 5 23:02:02 2022 +1300

    fix(nd): rect vis

commit 3a1caad
Author: Michael Corcoran <[email protected]>
Date:   Mon Dec 5 22:46:57 2022 +1300

    feat(pfd): true ref

    Still QFU dagger to be done (I think)

commit c67cbf5
Author: Michael Corcoran <[email protected]>
Date:   Mon Dec 5 22:44:29 2022 +1300

    feat(nd): true ref

    Still work to be done around radio nav indications.

commit dc707ef
Author: Michael Corcoran <[email protected]>
Date:   Mon Dec 5 22:41:23 2022 +1300

    feat(font): diamond for eis font

commit 7db9163
Author: Michael Corcoran <[email protected]>
Date:   Sun Dec 4 02:23:15 2022 +1300

    feat(adiru): polar heading/track
@tracernz tracernz enabled auto-merge (squash) January 11, 2023 04:29
@tracernz tracernz merged commit 82f9ad7 into flybywiresim:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwalschots davidwalschots davidwalschots left review comments

@Benjozork Benjozork Benjozork approved these changes

@lukecologne lukecologne Awaiting requested review from lukecologne

@crocket63 crocket63 Awaiting requested review from crocket63

Assignees
No one assigned
Labels
Exp Available on experimental branch (for testing) QA Tier 1
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tracernz @davidwalschots @Benjozork @2hwk