Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable parking brake so aircraft won't move during pre flight #7630

Merged
merged 5 commits into from
Jan 11, 2023

Conversation

Saschl
Copy link
Contributor

@Saschl Saschl commented Dec 1, 2022

Fixes #[issue_no]

Summary of Changes

Enables parking brake in taxi.flt so the aircraft won't move in the pre-flight cinematics.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Spawn on runway, make sure the aircraft won't move.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@tracernz
Copy link
Member

tracernz commented Dec 1, 2022

It's the most exciting part of the preflight cinematics! 😁

@Saschl
Copy link
Contributor Author

Saschl commented Dec 1, 2022

It's the most exciting part of the preflight cinematics! 😁

I love being in the dirt! :D

We could also let the MSFS AI steer our plane towards the runway👀

@2hwk
Copy link
Member

2hwk commented Dec 4, 2022

Just a note that this is a workaround and not a fix, it still will not work properly with the cinematic sequence but this is because we do not use the default MSFS parking brake system, and it is not possible to have the default parking brake system enabled and have custom parking brakes working. This is a sim issue and can't/won't be fixed.

@marcman86
Copy link
Contributor

Quality Assurance Report

Discord: marcman86#4907
Object of testing: #7630
Tier of Testing: 1
Date: 9/12/2022

Testing Process:

  • Spawned on runway 26R at EDDP
  • Waited a bit in pre flight to spot if aircraft moves > it did not

Negatives: -

Testing Results: Passed
Conclusions: Works for me

Hope this helps :-)

@Hellfire-2345
Copy link

Quality Assurance Trainee Report

Discord : hellfire#7383
Object of testing: #7630
Tier of Testing : 1
Date : 14/12/2022

Testing Process:
Runway 16R YSSY, had Parking brake on in preflight for some time and the aircraft didn't move

Negatives:
N/A

Testing Results:
Passed

Conclusions:
aircraft worked well.

@2hwk 2hwk added this to the v0.10.0 milestone Dec 14, 2022
@2hwk 2hwk added the QA Tier 1 label Dec 28, 2022
@mico975
Copy link
Contributor

mico975 commented Jan 11, 2023

Quality Assurance Tester Report

Discord : mico#3145
Object of testing: #7630
Tier of Testing : 1
Date : 11/01/2023

Testing Process:
Spawn on runway, make sure the aircraft won't move. - OK

Negatives:
N(A

Testing Results:
Passed

Conclusions:
LGTM

@Saschl Saschl enabled auto-merge (squash) January 11, 2023 20:50
@Saschl Saschl merged commit 48e77b2 into flybywiresim:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants