Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hyd): Simple hydraulic temperature simulation #7573

Merged

Conversation

crocket63
Copy link
Contributor

@crocket63 crocket63 commented Oct 28, 2022

Fixes #[issue_no]

Summary of Changes

Adds a simple temperature simulation to the hydraulics.

  • PTU can overheat if turning fast for a long time, and get permanently damaged.
  • PTU can overheat green or yellow fluid
  • Overheaten fluid going back to reservoir will trigger a reservoir overheat fault
  • Pumps taking fluid from overheating reservoir will lose efficiency
  • Electrical pumps can overheat causing increased power consumption / lower efficiency and permanent damage
  • Engine pumps can overheat
  • Any pump overheating will heat the fluid it uses
  • Updated ECAM SD Hyd page with OVHT info (Thanks Luke!)
  • Added placeolder ecam faults

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

This should not have any impact unless having failures.

Some test cases but you are free to fail anything you want:

  1. Empty green reservoir with PTU active. This is expected to cause a yellow circuit overheat causing the reservoir overheat fault on yellow side.
  2. Same with empty yellow causing a green overheat if PTU is active
  3. Blue and Yellow elec pumps should show an overheat ecam info on hyd screen when you have a heating failure on those pumps. It should cause an associated reservoir overheat. Pumps should work less and less efficiently and end up in total failure.
  4. Green and yellow engine pumps should cause a reservoir overheat when they have an overheat failure.
  5. When the cause of an overheating is not there anymore, overheat warnings should disapear after time.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@crocket63 crocket63 marked this pull request as ready for review October 31, 2022 09:01
.github/CHANGELOG.md Outdated Show resolved Hide resolved
src/instruments/src/Common/EWDMessages.tsx Show resolved Hide resolved
src/systems/a320_hydraulic_simulation_graphs/src/main.rs Outdated Show resolved Hide resolved
src/systems/a320_systems/src/hydraulic/mod.rs Outdated Show resolved Hide resolved
src/systems/a320_systems/src/hydraulic/mod.rs Outdated Show resolved Hide resolved
src/systems/systems/src/hydraulic/mod.rs Outdated Show resolved Hide resolved
src/systems/systems/src/hydraulic/mod.rs Outdated Show resolved Hide resolved
src/systems/systems/src/hydraulic/mod.rs Outdated Show resolved Hide resolved
src/systems/systems/src/hydraulic/mod.rs Outdated Show resolved Hide resolved
src/systems/systems/src/hydraulic/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Gurgel100 Gurgel100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great work

@alexr4339
Copy link

Quality Assurance Tester Report

Discord : Alex R#6663
Object of testing: #PR 7573
Tier of Testing : 1
Date : 22/12/2022

Testing Process:
Updated A32NX to latest experimental.
Loaded the aircraft on the runway.

  1. Selected the G RSVR leak failure on the EFB. PTU activated and after some time the Y RSVR OVHT showed on the HYD page as well as an ECAM message. The Y system lost pressure after some time.

Restarted the flight to make sure any previous failure is reset.

  1. Selected the Y RSVR leak failure on the EFB. PTU activated and after some time the G RSVR OVHT showed on the HYD page as well as an ECAM message. The G system also lost pressure after some time.

Restarted the flight again.

3, 4 and 5. Selected Y Eng pump ovht failure on the EFB and turned the PTU off. After some time the Y RSVR OVHT showedon the HYD page and as an ECAM message and the pressure dropped. Did the exact same procedure for the G eng pump ovht failure and it behaved exactly the same, as it was expected according to the PR description.
Selected the blue elec pump ovht failure. After some time ovht showed near the blue elec pump on the HYD page and no ECAM message appeared. That was expected. After some further time the Blue RSVR OVHT occured including an ECAM message and the pressure dropped.

Restarted the flight to the the Y ELEC pump

Selected Y ELEC pump ovht on the EFB. (Note engine was runnning). Nothing happened and I waited more than the time which it took for the B ELEC pump ovht to show on the HYD page. I turned the Y ELEC pump manually using the pushbutton on the overhead and checked after sometime the HYD page. When I opened the HYD page there was now an ovht next to the Y ELEC pump, no ECAM message or HYD SD pop up. Waited further time. No pressure lost and no RSVR ovht. (ENG pump still running and ELEC pump manually on). After some time the pump ovht warning was gone. At this point I turned the eng pump off manually with the Y ELEC pump still in the manual on position. The pressure dropped, indicating the Y ELEC pump has fully failed due to the ovht.

Negatives:
N/A

Testing Results:
Passed

Conclusions:
Everything works as expected according to the PR's description.

@crocket63 crocket63 enabled auto-merge (squash) December 27, 2022 07:55
@crocket63 crocket63 merged commit 18f7db2 into flybywiresim:master Dec 27, 2022
Eearslya pushed a commit to Eearslya/a32nx that referenced this pull request Jan 4, 2023

Co-authored-by: lukecologne <[email protected]>
Co-authored-by: Benedict Etzel <[email protected]>
Co-authored-by: Pascal Störzbach <[email protected]>
@crocket63 crocket63 deleted the feat_hyd_temperature_simulation branch April 16, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exp Available on experimental branch (for testing) Needs Code Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants