-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(efb): store pax seating in LVars (vs local storage) #7442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2hwk
changed the title
refactor: refer to loadsheet json for pax and cargo stations
refactor(efb): refer to loadsheet json for pax and cargo stations
Aug 27, 2022
beheh
previously requested changes
Sep 19, 2022
This comment was marked as outdated.
This comment was marked as outdated.
2hwk
force-pushed
the
flypad-weight-balance
branch
from
October 16, 2022 04:36
b2bb2a0
to
c61f2e9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
2hwk
force-pushed
the
flypad-weight-balance
branch
from
October 16, 2022 06:02
c61f2e9
to
68e6377
Compare
2hwk
force-pushed
the
flypad-weight-balance
branch
from
October 24, 2022 13:06
cd40270
to
7685f8c
Compare
2hwk
force-pushed
the
flypad-weight-balance
branch
from
December 21, 2022 12:13
7685f8c
to
7f87227
Compare
2hwk
changed the title
refactor(efb): refer to loadsheet json for pax and cargo stations
refactor(efb): store pax seating in LVars (vs local storage)
Dec 21, 2022
2hwk
force-pushed
the
flypad-weight-balance
branch
from
December 31, 2022 07:03
9677bdf
to
842e447
Compare
This reverts commit 68e6377.
2hwk
removed
the
Waiting for PR merge
Waiting for PR to be merged to fix the issue.
label
Jan 14, 2023
2hwk
force-pushed
the
flypad-weight-balance
branch
from
January 14, 2023 03:13
9781499
to
8b19239
Compare
2hwk
added a commit
that referenced
this pull request
Jan 15, 2023
13 tasks
2hwk
added
the
Waiting for PR merge
Waiting for PR to be merged to fix the issue.
label
Jan 17, 2023
2hwk
added a commit
that referenced
this pull request
Jan 18, 2023
Closing for now as this will be delayed until after #7695 has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
This is part 1 of a multi-part refactor, the next will be to move the boarding/cargo loading and synchronization of payload weights (the backend) into WASM (rust).
The first stage of this refactor is to move the bitwise flags that control passenger seating from localStorage (Which is slow and can only be accessed via coherentJS) into LocalVars instead, as well as to deprecate the old
TOTAL_ROWS_{}_{}
Local:Vars which are redundant with this bitpacked pax representation.This has several benefits:
Performance is much faster than using LocalStorage, where before frametimes could spike by 20ms or more with just 4 pax stations when trying to store several pax flag vars, now the impact is barely noticable to the end user (~1-2ms, which can be further improved).
Enables state saving/loading of seating by MSFS's default save file system
Allows manipulation of passenger seating in WASM (rust/C++), and allows other systems to be able to read current passenger location on a per passenger level of granularity (vs per section/payload station as before)
External programs can now set a seating layout by first setting the relevant
PAX_FLAG_{}_DESIRED
Local:Var with a bitpacked 64-bit long number, i.e. 7, or1111111
would set the first 7 seats in a passenger section (station) as seated, then start the boarding by setting theBOARDING_STARTED_BY_USR
Local:Var astrue
. This will start the boarding process as though it was triggered by the EFB.Changes
Screenshots (if necessary)
No visual changes
References
Additional context
Discord username (if different from GitHub):2Cas#1022
Testing instructions
Payload page should work as before
New Payload Backend
Check GSX Integration still works
There's a few things to be aware of when using GSX Sync.
3rd Party Options
. Inside there are two options to give you the freedom on what to sync with GSX. This activates the synchronisation. Without it GSX won't sync as expected. It's important to note various items and fields get disabled in the payload and fuel page with these options enabled.An aircraft profile is provided, you don't need to do anything GSX picks up on this
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.