feat(hyd): changed gear lever mechanism / added gear door drag #7390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocket63
changed the title
crocket63
changed the title
lukecologne
reviewed
Aug 11, 2022
…eat_custom_gear_lever_var
…eat_custom_gear_lever_var
Saschl
added a commit
to Saschl/a32nx
that referenced
this pull request
Dec 2, 2022
frankkopp
requested changes
Dec 3, 2022
Saschl
added a commit
to Saschl/a32nx
that referenced
this pull request
Dec 8, 2022
Saschl
added a commit
that referenced
this pull request
Dec 12, 2022
Saschl
added a commit
that referenced
this pull request
Dec 22, 2022
beheh
pushed a commit
that referenced
this pull request
Dec 22, 2022
Eearslya
pushed a commit
to Eearslya/a32nx
that referenced
this pull request
Jan 4, 2023
frankkopp
pushed a commit
that referenced
this pull request
Jan 19, 2023
(Rebase Fix: cherry-picked from commit 248fe73)
frankkopp
pushed a commit
that referenced
this pull request
Jan 22, 2023
(Rebase Fix: cherry-picked from commit 248fe73)
frankkopp
pushed a commit
that referenced
this pull request
Jan 23, 2023
(Rebase Fix: cherry-picked from commit 248fe73)
frankkopp
pushed a commit
that referenced
this pull request
Jan 24, 2023
(Rebase Fix: cherry-picked from commit 248fe73)
frankkopp
added a commit
that referenced
this pull request
Jan 27, 2023
feat(hyd): changed gear lever mechanism / added gear door drag (#7390) (Rebase Fix: cherry-picked from commit 248fe73) Rebase fixes Update to README files (fixes) Update to README files Adding a workflow for the branch to upload to CDN Fix a gitignore issue Fixing to build workflow for fragmenter Fixing A380 wasm build Update to eslint config and fixes for linter errors Updated script permissions for github actions Updated dev-env links to new environment Rebase fixes
frankkopp
added a commit
that referenced
this pull request
Jan 28, 2023
feat(hyd): changed gear lever mechanism / added gear door drag (#7390) (Rebase Fix: cherry-picked from commit 248fe73) Rebase fixes Update to README files (fixes) Update to README files Adding a workflow for the branch to upload to CDN Fix a gitignore issue Fixing to build workflow for fragmenter Fixing A380 wasm build Update to eslint config and fixes for linter errors Updated script permissions for github actions Updated dev-env links to new environment Rebase fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
Default gear lever mechanism using GEAR HANDLE POSITION simvar causes bugs with ground collision detection (landing gear down with gear lever up causes wheels going through the ground).
A custom lvar is added to handle the lever position only, and simvar GEAR HANDLE POSITION is built by system wasm depending on actual gear extension position
Added features:
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
Check everything that can be affected by a massive gear system hack.
Non regression check non exhaustive list:
...
New features:
Check that lever can be manipulated by mousewheel and drag in lock and legacy interaction modes.
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.